Sign upLogin

NYULibraries/getit

View on GitHub
Star
app/controllers/holding_requests_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method create has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if authorizer.present?
      # Is this a valid request type?
      valid_type = whitelist_type(params[:type])
      if valid_type
Severity: Minor
Found in app/controllers/holding_requests_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class HoldingRequestsController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class HoldingRequestsController < UmlautController
  # For now, a constant for the ILLiad URL
  ILLIAD_BASE_URL = (ENV['ILLIAD_BASE_URL'] || 'http://ill.library.nyu.edu')

  # E-ZBorrow URL
Severity: Minor
Found in app/controllers/holding_requests_controller.rb - About 2 hrs to fix

    Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
    if authorizer.present?
      # Is this a valid request type?
      valid_type = whitelist_type(params[:type])
      if valid_type
    Severity: Minor
    Found in app/controllers/holding_requests_controller.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  unless create_hold.error?
              # Create the holding request for the current user
              redirect_to(holding_request_path(service_response, entire: entire, pickup_location: pickup_location.code))
            else
              flash[:alert] = create_hold.note
      Severity: Major
      Found in app/controllers/holding_requests_controller.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status