Sign upLogin

NYULibraries/getit

View on GitHub
Star
app/helpers/application_helper.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method expire_or_destroy_nyu_primo_source_service_responses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def expire_or_destroy_nyu_primo_source_service_responses(request)
    # Only do this after all services have finished.
    unless request.any_services_in_progress?
      nyu_primo_source_service_responses =
        request.service_responses.where(service_id: 'NYU_Primo_Source')
Severity: Minor
Found in app/helpers/application_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method destroy_successful_nyu_primo_source_dispatched_services has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def destroy_successful_nyu_primo_source_dispatched_services(request)
    # Only do this after all services have finished.
    unless request.any_services_in_progress?
      nyu_primo_source_dispatched_services =
        request.dispatched_services.where(service_id: 'NYU_Primo_Source')
Severity: Minor
Found in app/helpers/application_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status