app/helpers/nyulibraries/assets/institutions_helper.rb
Method reload_ip_addresses_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def reload_ip_addresses_for(institution)
institution_ip_addresses = []
Institutions.loadfiles.each do |loadfile|
# Loop through institutions in the yaml
YAML.load(ERB.new(File.read(loadfile)).result).each_pair do |code, elements|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method url_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def url_for(options={})
if institution_param.present? and options.is_a? Hash
options[institution_param_name] ||= institution_param
end
if institute_param.present? and options.is_a? Hash- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"