Sign upLogin

Narazaka/fso

View on GitHub
Star

Showing 13 of 13 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

for (const _method of fdMethods) {
  FileSystemObject.prototype[_method] = (function(method) {
    return function(...args) {
      if (args[args.length - 1] instanceof Function) {
        fs[method](this.fd, ...args);
Severity: Major
Found in src/lib/fso.js and 2 other locations - About 1 day to fix
src/lib/fso.js on lines 475..494
src/lib/fso.js on lines 550..569

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 217.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

for (const _method of singlePathMethods) {
  FileSystemObject.prototype[_method] = (function(method) {
    return function(...args) {
      if (args[args.length - 1] instanceof Function) {
        fs[method](this.path, ...args);
Severity: Major
Found in src/lib/fso.js and 2 other locations - About 1 day to fix
src/lib/fso.js on lines 529..548
src/lib/fso.js on lines 550..569

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 217.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

for (const _method of fdMultiReturnMethods) {
  FileSystemObject.prototype[_method] = (function(method) {
    return function(...args) {
      if (args[args.length - 1] instanceof Function) {
        fs[method](this.fd, ...args);
Severity: Major
Found in src/lib/fso.js and 2 other locations - About 1 day to fix
src/lib/fso.js on lines 475..494
src/lib/fso.js on lines 529..548

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 217.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File fso.js has 526 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const fs = require("fs");
const path = require("path");

const singlePathMethods = [
  "access",
Severity: Major
Found in src/lib/fso.js - About 1 day to fix

    FileSystemObject has 54 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class FileSystemObject {
  constructor(...paths) {
    this.path = path.join(...paths);
  }
    Severity: Major
    Found in src/lib/fso.js - About 7 hrs to fix

      Function _filterChildren has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        static async _filterChildren(children, excepts, hasCallback) {
    if (!excepts) {
      return children;
    } else if (excepts instanceof Array) {
      return FileSystemObject._filterChildrenByPaths(children, excepts);
      Severity: Minor
      Found in src/lib/fso.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (callback) {
      let children;
      try {
        children = await FileSystemObject._childrenRecursive(this, _excepts, true);
      } catch (error) {
      Severity: Major
      Found in src/lib/fso.js and 1 other location - About 1 hr to fix
      src/lib/fso.js on lines 376..387

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (callback) {
      let children;
      try {
        children = await FileSystemObject._childrenRecursive(this, undefined, true);
      } catch (error) {
      Severity: Major
      Found in src/lib/fso.js and 1 other location - About 1 hr to fix
      src/lib/fso.js on lines 451..462

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _method has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        FileSystemObject.prototype[_method] = (function(method) {
    return function(...args) {
      if (args[args.length - 1] instanceof Function) {
        fs[method](this.path, ...args);
      } else {
      Severity: Minor
      Found in src/lib/fso.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _method has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        FileSystemObject.prototype[_method] = (function(method) {
    return function(...args) {
      if (args[args.length - 1] instanceof Function) {
        fs[method](this.fd, ...args);
      } else {
      Severity: Minor
      Found in src/lib/fso.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _method has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        FileSystemObject.prototype[_method] = (function(method) {
    return function(...args) {
      if (args[args.length - 1] instanceof Function) {
        fs[method](this.fd, ...args);
      } else {
      Severity: Minor
      Found in src/lib/fso.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function rmAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        async rmAll(callback) {
    try {
      for (const child of (await this.childrenAll()).reverse()) {
        if (await child.isDirectory()) {
          await child.rmdir();
      Severity: Minor
      Found in src/lib/fso.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function filteredMergeDirectory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        async filteredMergeDirectory(source, excepts, callback) {
    try {
      for (const child of await source.filteredChildrenAll(excepts)) {
        const relativePath = source.relative(child.toString());
        const childTarget = this.new(relativePath.toString());
      Severity: Minor
      Found in src/lib/fso.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language