Sign upLogin

NatLibFi/Annif

View on GitHub
Star
annif/backend/nn_ensemble.py

Summary

Maintainability
A
1 hr
Test Coverage

File nn_ensemble.py has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

"""Neural network based ensemble backend that combines results from multiple
projects."""

from __future__ import annotations
Severity: Minor
Found in annif/backend/nn_ensemble.py - About 2 hrs to fix

    Function _fit_model has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Invalid

        def _fit_model(
    Severity: Minor
    Found in annif/backend/nn_ensemble.py - About 35 mins to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          def _merge_source_batches(
        self,
        batch_by_source: dict[str, SuggestionBatch],
        sources: list[tuple[str, float]],
        params: dict[str, Any],
      Severity: Major
      Found in annif/backend/nn_ensemble.py and 2 other locations - About 1 hr to fix
      annif/backend/ensemble.py on lines 51..55
      annif/backend/pav.py on lines 62..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status