NatLibFi/Skosmos

View on GitHub
src/controller/RestController.php

Summary

Maintainability
F
1 wk
Test Coverage
F
22%

File RestController.php has 883 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * RestController is responsible for handling all the requests directed to the /rest address.
 */
Severity: Major
Found in src/controller/RestController.php - About 2 days to fix

    Function hierarchy has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

        public function hierarchy($request)
        {
            if ($this->notModified($request->getVocab())) {
                return null;
            }
    Severity: Minor
    Found in src/controller/RestController.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function findLookupHits has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        private function findLookupHits($results, $label, $lang)
        {
            $hits = array();
            // case 1: exact match on preferred label
            foreach ($results as $res) {
    Severity: Minor
    Found in src/controller/RestController.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    RestController has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class RestController extends Controller
    {
        /* supported MIME types that can be used to return RDF data */
        public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
        /* context array template */
    Severity: Minor
    Found in src/controller/RestController.php - About 4 hrs to fix

      The class RestController has 35 non-getter- and setter-methods. Consider refactoring RestController to keep number of methods under 25.
      Open

      class RestController extends Controller
      {
          /* supported MIME types that can be used to return RDF data */
          public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
          /* context array template */
      Severity: Minor
      Found in src/controller/RestController.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      The class RestController has an overall complexity of 198 which is very high. The configured complexity threshold is 50.
      Open

      class RestController extends Controller
      {
          /* supported MIME types that can be used to return RDF data */
          public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
          /* context array template */
      Severity: Minor
      Found in src/controller/RestController.php by phpmd

      The class RestController has 24 public methods. Consider refactoring RestController to keep number of public methods under 10.
      Open

      class RestController extends Controller
      {
          /* supported MIME types that can be used to return RDF data */
          public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
          /* context array template */
      Severity: Minor
      Found in src/controller/RestController.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      Method vocabularyStatistics has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function vocabularyStatistics($request)
          {
              if ($this->notModified($request->getVocab())) {
                  return null;
              }
      Severity: Major
      Found in src/controller/RestController.php - About 2 hrs to fix

        Method hierarchy has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function hierarchy($request)
            {
                if ($this->notModified($request->getVocab())) {
                    return null;
                }
        Severity: Major
        Found in src/controller/RestController.php - About 2 hrs to fix

          Method findLookupHits has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function findLookupHits($results, $label, $lang)
              {
                  $hits = array();
                  // case 1: exact match on preferred label
                  foreach ($results as $res) {
          Severity: Major
          Found in src/controller/RestController.php - About 2 hrs to fix

            Function transformSearchResults has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                private function transformSearchResults($request, $results, $parameters)
                {
                    // before serializing to JSON, get rid of the Vocabulary object that came with each resource
                    foreach ($results as &$res) {
                        unset($res['voc']);
            Severity: Minor
            Found in src/controller/RestController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method labelStatistics has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function labelStatistics($request)
                {
                    if ($this->notModified($request->getVocab())) {
                        return null;
                    }
            Severity: Minor
            Found in src/controller/RestController.php - About 1 hr to fix

              Method transformSearchResults has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function transformSearchResults($request, $results, $parameters)
                  {
                      // before serializing to JSON, get rid of the Vocabulary object that came with each resource
                      foreach ($results as &$res) {
                          unset($res['voc']);
              Severity: Minor
              Found in src/controller/RestController.php - About 1 hr to fix

                Method vocabularyInformation has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function vocabularyInformation($request)
                    {
                        $vocab = $request->getVocab();
                        if ($this->notModified($vocab)) {
                            return null;
                Severity: Minor
                Found in src/controller/RestController.php - About 1 hr to fix

                  Method returnDataResults has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function returnDataResults($results, $format)
                      {
                          if ($format == 'application/ld+json' || $format == 'application/json') {
                              // further compact JSON-LD document using a context
                              $context = array(
                  Severity: Minor
                  Found in src/controller/RestController.php - About 1 hr to fix

                    Method types has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function types($request)
                        {
                            $vocid = $request->getVocab() ? $request->getVocab()->getId() : null;
                            if ($vocid === null && !$request->getLang()) {
                                return $this->returnError(400, "Bad Request", "lang parameter missing");
                    Severity: Minor
                    Found in src/controller/RestController.php - About 1 hr to fix

                      Method vocabularies has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function vocabularies($request)
                          {
                              if (!$request->getLang()) {
                                  return $this->returnError(400, "Bad Request", "lang parameter missing");
                              }
                      Severity: Minor
                      Found in src/controller/RestController.php - About 1 hr to fix

                        Function changedConcepts has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function changedConcepts($request, $prop, $offset, $limit)
                            {
                                $changeList = $request->getVocab()->getChangeList($prop, $request->getLang(), $offset, $limit);
                        
                                $simpleChangeList = array();
                        Severity: Minor
                        Found in src/controller/RestController.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method mappings has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function mappings(Request $request)
                            {
                                $this->model->setLocale($request->getLang());
                                $vocab = $request->getVocab();
                                if ($this->notModified($vocab)) {
                        Severity: Minor
                        Found in src/controller/RestController.php - About 1 hr to fix

                          Method label has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function label($request)
                              {
                                  if (!$request->getUri()) {
                                      return $this->returnError(400, "Bad Request", "uri parameter missing");
                                  }
                          Severity: Minor
                          Found in src/controller/RestController.php - About 1 hr to fix

                            Method changedConcepts has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                private function changedConcepts($request, $prop, $offset, $limit)
                                {
                                    $changeList = $request->getVocab()->getChangeList($prop, $request->getLang(), $offset, $limit);
                            
                                    $simpleChangeList = array();
                            Severity: Minor
                            Found in src/controller/RestController.php - About 1 hr to fix

                              Method transformTransitivePropertyResults has 7 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  private function transformTransitivePropertyResults($uri, $lang, $objects, $tpropname, $tpropuri, $dpropname, $dpropuri)
                              Severity: Major
                              Found in src/controller/RestController.php - About 50 mins to fix

                                Function search has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function search(Request $request): void
                                    {
                                        $maxhits = $request->getQueryParam('maxhits');
                                        $offset = $request->getQueryParam('offset');
                                        $term = $request->getQueryParamRaw('query');
                                Severity: Minor
                                Found in src/controller/RestController.php - About 45 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method transformPropertyResults has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    private function transformPropertyResults($uri, $lang, $objects, $propname, $propuri)
                                Severity: Minor
                                Found in src/controller/RestController.php - About 35 mins to fix

                                  Function vocabularyStatistics has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function vocabularyStatistics($request)
                                      {
                                          if ($this->notModified($request->getVocab())) {
                                              return null;
                                          }
                                  Severity: Minor
                                  Found in src/controller/RestController.php - About 35 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function redirectToVocabData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private function redirectToVocabData($request)
                                      {
                                          $urls = $request->getVocab()->getConfig()->getDataURLs();
                                          if (sizeof($urls) == 0) {
                                              $vocid = $request->getVocab()->getId();
                                  Severity: Minor
                                  Found in src/controller/RestController.php - About 35 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function labelStatistics has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function labelStatistics($request)
                                      {
                                          if ($this->notModified($request->getVocab())) {
                                              return null;
                                          }
                                  Severity: Minor
                                  Found in src/controller/RestController.php - About 35 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Avoid too many return statements within this method.
                                  Open

                                              return $this->returnError(404, 'Bad Request', "no concept found with given uri");
                                  Severity: Major
                                  Found in src/controller/RestController.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return $this->returnDataResults($results, $format);
                                    Severity: Major
                                    Found in src/controller/RestController.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                  return $hits;
                                      Severity: Major
                                      Found in src/controller/RestController.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                return $hits;
                                        Severity: Major
                                        Found in src/controller/RestController.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                      return $hits;
                                          Severity: Major
                                          Found in src/controller/RestController.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                    return $this->returnJson($ret);
                                            Severity: Major
                                            Found in src/controller/RestController.php - About 30 mins to fix

                                              Function data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                              Open

                                                  public function data($request)
                                                  {
                                                      $vocab = $request->getVocab();
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                              Severity: Minor
                                              Found in src/controller/RestController.php - About 25 mins to fix

                                              Cognitive Complexity

                                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                              A method's cognitive complexity is based on a few simple rules:

                                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                              • Code is considered more complex for each "break in the linear flow of the code"
                                              • Code is considered more complex when "flow breaking structures are nested"

                                              Further reading

                                              Function mappings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                              Open

                                                  public function mappings(Request $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                                      $vocab = $request->getVocab();
                                                      if ($this->notModified($vocab)) {
                                              Severity: Minor
                                              Found in src/controller/RestController.php - About 25 mins to fix

                                              Cognitive Complexity

                                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                              A method's cognitive complexity is based on a few simple rules:

                                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                              • Code is considered more complex for each "break in the linear flow of the code"
                                              • Code is considered more complex when "flow breaking structures are nested"

                                              Further reading

                                              Function label has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                              Open

                                                  public function label($request)
                                                  {
                                                      if (!$request->getUri()) {
                                                          return $this->returnError(400, "Bad Request", "uri parameter missing");
                                                      }
                                              Severity: Minor
                                              Found in src/controller/RestController.php - About 25 mins to fix

                                              Cognitive Complexity

                                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                              A method's cognitive complexity is based on a few simple rules:

                                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                              • Code is considered more complex for each "break in the linear flow of the code"
                                              • Code is considered more complex when "flow breaking structures are nested"

                                              Further reading

                                              The class RestController has 1172 lines of code. Current threshold is 1000. Avoid really long classes.
                                              Open

                                              class RestController extends Controller
                                              {
                                                  /* supported MIME types that can be used to return RDF data */
                                                  public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
                                                  /* context array template */
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              The method hierarchy() has an NPath complexity of 756. The configured NPath complexity threshold is 200.
                                              Open

                                                  public function hierarchy($request)
                                                  {
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                                      }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              NPathComplexity

                                              Since: 0.1

                                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                              Example

                                              class Foo {
                                                  function bar() {
                                                      // lots of complicated code
                                                  }
                                              }

                                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                              The method findLookupHits() has an NPath complexity of 266240. The configured NPath complexity threshold is 200.
                                              Open

                                                  private function findLookupHits($results, $label, $lang)
                                                  {
                                                      $hits = array();
                                                      // case 1: exact match on preferred label
                                                      foreach ($results as $res) {
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              NPathComplexity

                                              Since: 0.1

                                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                              Example

                                              class Foo {
                                                  function bar() {
                                                      // lots of complicated code
                                                  }
                                              }

                                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                              The method findLookupHits() has a Cyclomatic Complexity of 26. The configured cyclomatic complexity threshold is 10.
                                              Open

                                                  private function findLookupHits($results, $label, $lang)
                                                  {
                                                      $hits = array();
                                                      // case 1: exact match on preferred label
                                                      foreach ($results as $res) {
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CyclomaticComplexity

                                              Since: 0.1

                                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                              Example

                                              // Cyclomatic Complexity = 11
                                              class Foo {
                                              1   public function example() {
                                              2       if ($a == $b) {
                                              3           if ($a1 == $b1) {
                                                              fiddle();
                                              4           } elseif ($a2 == $b2) {
                                                              fiddle();
                                                          } else {
                                                              fiddle();
                                                          }
                                              5       } elseif ($c == $d) {
                                              6           while ($c == $d) {
                                                              fiddle();
                                                          }
                                              7        } elseif ($e == $f) {
                                              8           for ($n = 0; $n < $h; $n++) {
                                                              fiddle();
                                                          }
                                                      } else {
                                                          switch ($z) {
                                              9               case 1:
                                                                  fiddle();
                                                                  break;
                                              10              case 2:
                                                                  fiddle();
                                                                  break;
                                              11              case 3:
                                                                  fiddle();
                                                                  break;
                                                              default:
                                                                  fiddle();
                                                                  break;
                                                          }
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                              The method search() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                              Open

                                                  public function search(Request $request): void
                                                  {
                                                      $maxhits = $request->getQueryParam('maxhits');
                                                      $offset = $request->getQueryParam('offset');
                                                      $term = $request->getQueryParamRaw('query');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CyclomaticComplexity

                                              Since: 0.1

                                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                              Example

                                              // Cyclomatic Complexity = 11
                                              class Foo {
                                              1   public function example() {
                                              2       if ($a == $b) {
                                              3           if ($a1 == $b1) {
                                                              fiddle();
                                              4           } elseif ($a2 == $b2) {
                                                              fiddle();
                                                          } else {
                                                              fiddle();
                                                          }
                                              5       } elseif ($c == $d) {
                                              6           while ($c == $d) {
                                                              fiddle();
                                                          }
                                              7        } elseif ($e == $f) {
                                              8           for ($n = 0; $n < $h; $n++) {
                                                              fiddle();
                                                          }
                                                      } else {
                                                          switch ($z) {
                                              9               case 1:
                                                                  fiddle();
                                                                  break;
                                              10              case 2:
                                                                  fiddle();
                                                                  break;
                                              11              case 3:
                                                                  fiddle();
                                                                  break;
                                                              default:
                                                                  fiddle();
                                                                  break;
                                                          }
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                              The method hierarchy() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
                                              Open

                                                  public function hierarchy($request)
                                                  {
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                                      }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CyclomaticComplexity

                                              Since: 0.1

                                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                              Example

                                              // Cyclomatic Complexity = 11
                                              class Foo {
                                              1   public function example() {
                                              2       if ($a == $b) {
                                              3           if ($a1 == $b1) {
                                                              fiddle();
                                              4           } elseif ($a2 == $b2) {
                                                              fiddle();
                                                          } else {
                                                              fiddle();
                                                          }
                                              5       } elseif ($c == $d) {
                                              6           while ($c == $d) {
                                                              fiddle();
                                                          }
                                              7        } elseif ($e == $f) {
                                              8           for ($n = 0; $n < $h; $n++) {
                                                              fiddle();
                                                          }
                                                      } else {
                                                          switch ($z) {
                                              9               case 1:
                                                                  fiddle();
                                                                  break;
                                              10              case 2:
                                                                  fiddle();
                                                                  break;
                                              11              case 3:
                                                                  fiddle();
                                                                  break;
                                                              default:
                                                                  fiddle();
                                                                  break;
                                                          }
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                              The method vocabularyStatistics() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                              Open

                                                  public function vocabularyStatistics($request)
                                                  {
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                                      }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CyclomaticComplexity

                                              Since: 0.1

                                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                              Example

                                              // Cyclomatic Complexity = 11
                                              class Foo {
                                              1   public function example() {
                                              2       if ($a == $b) {
                                              3           if ($a1 == $b1) {
                                                              fiddle();
                                              4           } elseif ($a2 == $b2) {
                                                              fiddle();
                                                          } else {
                                                              fiddle();
                                                          }
                                              5       } elseif ($c == $d) {
                                              6           while ($c == $d) {
                                                              fiddle();
                                                          }
                                              7        } elseif ($e == $f) {
                                              8           for ($n = 0; $n < $h; $n++) {
                                                              fiddle();
                                                          }
                                                      } else {
                                                          switch ($z) {
                                              9               case 1:
                                                                  fiddle();
                                                                  break;
                                              10              case 2:
                                                                  fiddle();
                                                                  break;
                                              11              case 3:
                                                                  fiddle();
                                                                  break;
                                                              default:
                                                                  fiddle();
                                                                  break;
                                                          }
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                              Missing class import via use statement (line '709', column '33').
                                              Open

                                                      $linkUrlExtension = new LinkUrlExtension($this->model);
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              MissingImport

                                              Since: 2.7.0

                                              Importing all external classes in a file through use statements makes them clearly visible.

                                              Example

                                              function make() {
                                                  return new \stdClass();
                                              }

                                              Source http://phpmd.org/rules/cleancode.html#MissingImport

                                              Missing class import via use statement (line '102', column '27').
                                              Open

                                                      $parameters = new ConceptSearchParameters($request, $this->model->getConfig(), true);
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              MissingImport

                                              Since: 2.7.0

                                              Importing all external classes in a file through use statements makes them clearly visible.

                                              Example

                                              function make() {
                                                  return new \stdClass();
                                              }

                                              Source http://phpmd.org/rules/cleancode.html#MissingImport

                                              Missing class import via use statement (line '33', column '27').
                                              Open

                                                      $negotiator = new \Negotiation\Negotiator();
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              MissingImport

                                              Since: 2.7.0

                                              Importing all external classes in a file through use statements makes them clearly visible.

                                              Example

                                              function make() {
                                                  return new \stdClass();
                                              }

                                              Source http://phpmd.org/rules/cleancode.html#MissingImport

                                              Missing class import via use statement (line '545', column '27').
                                              Open

                                                      $parameters = new ConceptSearchParameters($request, $this->model->getConfig(), true);
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              MissingImport

                                              Since: 2.7.0

                                              Importing all external classes in a file through use statements makes them clearly visible.

                                              Example

                                              function make() {
                                                  return new \stdClass();
                                              }

                                              Source http://phpmd.org/rules/cleancode.html#MissingImport

                                              The method redirectToVocabData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                              Open

                                                      } else {
                                                          header("Location: " . $urls[$format]);
                                                      }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              ElseExpression

                                              Since: 1.4.0

                                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                              Example

                                              class Foo
                                              {
                                                  public function bar($flag)
                                                  {
                                                      if ($flag) {
                                                          // one branch
                                                      } else {
                                                          // another branch
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                                              Avoid using static access to class 'EasyRdf\RdfNamespace' in method 'vocabularyStatistics'.
                                              Open

                                                              'label' => isset($vocabStats[$arrayClass]['label']) ? $vocabStats[$arrayClass]['label'] : $this->model->getText(EasyRdf\RdfNamespace::shorten($arrayClass)),
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              StaticAccess

                                              Since: 1.4.0

                                              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                              Example

                                              class Foo
                                              {
                                                  public function bar()
                                                  {
                                                      Bar::baz();
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#staticaccess

                                              The method data uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                              Open

                                                      } else {
                                                          return $this->returnError(400, 'Bad Request', "uri parameter missing");
                                                      }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              ElseExpression

                                              Since: 1.4.0

                                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                              Example

                                              class Foo
                                              {
                                                  public function bar($flag)
                                                  {
                                                      if ($flag) {
                                                          // one branch
                                                      } else {
                                                          // another branch
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                                              The method hierarchy uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                              Open

                                                              } else {
                                                                  // no main concept scheme set on the vocab, take the first value of 'tops' (sorted alphabetically)
                                                                  $results[$uri]['top'] = $results[$uri]['tops'][0];
                                                              }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              ElseExpression

                                              Since: 1.4.0

                                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                              Example

                                              class Foo
                                              {
                                                  public function bar($flag)
                                                  {
                                                      if ($flag) {
                                                          // one branch
                                                      } else {
                                                          // another branch
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                                              Avoid using static access to class 'Punic\Language' in method 'labelStatistics'.
                                              Open

                                                              $langdata['literal'] = Punic\Language::getName($proplang, $lang);
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              StaticAccess

                                              Since: 1.4.0

                                              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                              Example

                                              class Foo
                                              {
                                                  public function bar()
                                                  {
                                                      Bar::baz();
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#staticaccess

                                              Avoid using static access to class 'EasyRdf\RdfNamespace' in method 'vocabularyStatistics'.
                                              Open

                                                              'label' => isset($vocabStats[$groupClass]['label']) ? $vocabStats[$groupClass]['label'] : $this->model->getText(EasyRdf\RdfNamespace::shorten($groupClass)),
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              StaticAccess

                                              Since: 1.4.0

                                              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                              Example

                                              class Foo
                                              {
                                                  public function bar()
                                                  {
                                                      Bar::baz();
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#staticaccess

                                              The method redirectToVocabData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                              Open

                                                          } else {
                                                              $vocid = $request->getVocab()->getId();
                                                              return $this->returnError('404', 'Not Found', "No download source URL known for vocabulary $vocid in language $dataLang");
                                                          }
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              ElseExpression

                                              Since: 1.4.0

                                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                              Example

                                              class Foo
                                              {
                                                  public function bar($flag)
                                                  {
                                                      if ($flag) {
                                                          // one branch
                                                      } else {
                                                          // another branch
                                                      }
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                                              Avoid using static access to class '\ML\JsonLD\JsonLD' in method 'returnDataResults'.
                                              Open

                                                          $compactJsonLD = \ML\JsonLD\JsonLD::compact($results, json_encode($context));
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              StaticAccess

                                              Since: 1.4.0

                                              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                              Example

                                              class Foo
                                              {
                                                  public function bar()
                                                  {
                                                      Bar::baz();
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#staticaccess

                                              Avoid using static access to class '\ML\JsonLD\JsonLD' in method 'returnDataResults'.
                                              Open

                                                          $results = \ML\JsonLD\JsonLD::toString($compactJsonLD);
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              StaticAccess

                                              Since: 1.4.0

                                              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                              Example

                                              class Foo
                                              {
                                                  public function bar()
                                                  {
                                                      Bar::baz();
                                                  }
                                              }

                                              Source https://phpmd.org/rules/cleancode.html#staticaccess

                                              Similar blocks of code found in 2 locations. Consider refactoring.
                                              Open

                                                  public function newConcepts($request)
                                                  {
                                                      $offset = ($request->getQueryParam('offset') && is_numeric($request->getQueryParam('offset')) && $request->getQueryParam('offset') >= 0) ? $request->getQueryParam('offset') : 0;
                                                      $limit = ($request->getQueryParam('limit') && is_numeric($request->getQueryParam('limit')) && $request->getQueryParam('limit') >= 0) ? $request->getQueryParam('limit') : 200;
                                              
                                              
                                              Severity: Major
                                              Found in src/controller/RestController.php and 1 other location - About 2 hrs to fix
                                              src/controller/RestController.php on lines 1131..1137

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 138.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              Similar blocks of code found in 2 locations. Consider refactoring.
                                              Open

                                                  public function modifiedConcepts($request)
                                                  {
                                                      $offset = ($request->getQueryParam('offset') && is_numeric($request->getQueryParam('offset')) && $request->getQueryParam('offset') >= 0) ? $request->getQueryParam('offset') : 0;
                                                      $limit = ($request->getQueryParam('limit') && is_numeric($request->getQueryParam('limit')) && $request->getQueryParam('limit') >= 0) ? $request->getQueryParam('limit') : 200;
                                              
                                              
                                              Severity: Major
                                              Found in src/controller/RestController.php and 1 other location - About 2 hrs to fix
                                              src/controller/RestController.php on lines 1118..1124

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 138.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              Similar blocks of code found in 3 locations. Consider refactoring.
                                              Open

                                                  public function related($request)
                                                  {
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                                      }
                                              Severity: Major
                                              Found in src/controller/RestController.php and 2 other locations - About 2 hrs to fix
                                              src/controller/RestController.php on lines 869..880
                                              src/controller/RestController.php on lines 905..916

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 127.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              Similar blocks of code found in 3 locations. Consider refactoring.
                                              Open

                                                  public function broader($request)
                                                  {
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                                      }
                                              Severity: Major
                                              Found in src/controller/RestController.php and 2 other locations - About 2 hrs to fix
                                              src/controller/RestController.php on lines 905..916
                                              src/controller/RestController.php on lines 1100..1111

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 127.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              Similar blocks of code found in 3 locations. Consider refactoring.
                                              Open

                                                  public function narrower($request)
                                                  {
                                                      if ($this->notModified($request->getVocab())) {
                                                          return null;
                                                      }
                                              Severity: Major
                                              Found in src/controller/RestController.php and 2 other locations - About 2 hrs to fix
                                              src/controller/RestController.php on lines 869..880
                                              src/controller/RestController.php on lines 1100..1111

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 127.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              Similar blocks of code found in 2 locations. Consider refactoring.
                                              Open

                                                      } elseif (isset($vocabStats[$arrayClass])) {
                                                          $ret['arrays'] = array(
                                                              'class' => $arrayClass,
                                                              'label' => isset($vocabStats[$arrayClass]['label']) ? $vocabStats[$arrayClass]['label'] : $this->model->getText(EasyRdf\RdfNamespace::shorten($arrayClass)),
                                                              'count' => $vocabStats[$arrayClass]['count'],
                                              Severity: Minor
                                              Found in src/controller/RestController.php and 1 other location - About 50 mins to fix
                                              src/controller/RestController.php on lines 312..319

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 97.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              Similar blocks of code found in 2 locations. Consider refactoring.
                                              Open

                                                      } elseif (isset($vocabStats[$groupClass])) {
                                                          $ret['conceptGroups'] = array(
                                                              'class' => $groupClass,
                                                              'label' => isset($vocabStats[$groupClass]['label']) ? $vocabStats[$groupClass]['label'] : $this->model->getText(EasyRdf\RdfNamespace::shorten($groupClass)),
                                                              'count' => $vocabStats[$groupClass]['count'],
                                              Severity: Minor
                                              Found in src/controller/RestController.php and 1 other location - About 50 mins to fix
                                              src/controller/RestController.php on lines 319..326

                                              Duplicated Code

                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                              Tuning

                                              This issue has a mass of 97.

                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                              Refactorings

                                              Further Reading

                                              The variable $offset_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $offset_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $limit_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $limit_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $offset_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $offset_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $limit_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              The variable $limit_param is not named in camelCase.
                                              Open

                                                  public function indexConcepts($letter, $request)
                                                  {
                                                      $this->model->setLocale($request->getLang());
                                              
                                                      $offset_param = $request->getQueryParam('offset');
                                              Severity: Minor
                                              Found in src/controller/RestController.php by phpmd

                                              CamelCaseVariableName

                                              Since: 0.2

                                              It is considered best practice to use the camelCase notation to name variables.

                                              Example

                                              class ClassName {
                                                  public function doSomething() {
                                                      $data_module = new DataModule();
                                                  }
                                              }

                                              Source

                                              There are no issues that match your filters.

                                              Category
                                              Status