src/model/BaseConfig.php
The method getBoolean has a boolean flag argument $default, which is a certain sign of a Single Responsibility Principle violation. Open
Open
protected function getBoolean($property, $default = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The 'getBoolean()' method which returns a boolean should be named 'is...()' or 'has...()' Open
Open
protected function getBoolean($property, $default = false)
{
$val = $this->getResource()->getLiteral($property);
if ($val) {
return filter_var($val->getValue(), FILTER_VALIDATE_BOOLEAN);- Read upRead up
- Exclude checks
BooleanGetMethodName
Since: 0.2
Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.
Example
class Foo {
/**
* @return boolean
*/
public function getFoo() {} // bad
/**
* @return bool
*/
public function isFoo(); // ok
/**
* @return boolean
*/
public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}