Sign upLogin

NatLibFi/Skosmos

View on GitHub
Star
src/model/ConceptPropertyValueLiteral.php

Summary

Maintainability
A
45 mins
Test Coverage
A
95%

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($model, $vocab, $resource, $literal, $prop, $clang = '')
Severity: Minor
Found in src/model/ConceptPropertyValueLiteral.php - About 45 mins to fix

    Missing class import via use statement (line '105', column '24').
    Open

                return new LabelSkosXL($this->model, $labres);
    Severity: Minor
    Found in src/model/ConceptPropertyValueLiteral.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Punic\Calendar' in method 'getLabel'.
    Open

                    return Punic\Calendar::formatDate($val, 'short');
    Severity: Minor
    Found in src/model/ConceptPropertyValueLiteral.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status