src/model/ConceptSearchParameters.php
The class ConceptSearchParameters has an overall complexity of 59 which is very high. The configured complexity threshold is 50. Open
Open
class ConceptSearchParameters
{
private $config;
private $request;
private $vocabs;- Exclude checks
ConceptSearchParameters has 24 functions (exceeds 20 allowed). Consider refactoring. Open
Open
class ConceptSearchParameters
{
private $config;
private $request;
private $vocabs;The method __construct has a boolean flag argument $rest, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($request, $config, $rest = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Normalizer' in method 'getSearchTerm'. Open
Open
$term = Normalizer::normalize($term, Normalizer::FORM_C); //Normalize decomposed unicode characters #1184- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}