NatLibFi/marc-record-js

View on GitHub

Showing 87 of 87 total issues

Avoid too many return statements within this function.
Open

          return record.pop(what); // eslint-disable-line functional/immutable-data
Severity: Major
Found in src/index.spec.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return MarcRecord.setValidationOptions(args);
    Severity: Major
    Found in src/index.spec.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return record.isBK();
      Severity: Major
      Found in src/index.spec.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return record.isMP();
        Severity: Major
        Found in src/index.spec.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return record.getDatafields();
          Severity: Major
          Found in src/index.spec.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return record.toString().split('\n');
            Severity: Major
            Found in src/index.spec.js - About 30 mins to fix

              Function sortByTag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              export function sortByTag(fieldA, fieldB) {
              
                function getSortIndex(tag) {
                  const sortIndex = {
                    LDR: '000',
              Severity: Minor
              Found in src/marcFieldSort.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language