Sign upLogin

NatLibFi/marc-record-validate

View on GitHub
Star

Showing 4 of 4 total issues

Function default has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function (validators = []) {
  if (validators.length === 0) { // eslint-disable-line functional/no-conditional-statements
    throw new Error('No validators provided');
  }
Severity: Major
Found in src/index.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(result.record.toObject()).to.eql({
      leader: '',
      fields: [
        {tag: 'FOO', value: 'foo'},
        {tag: 'BAR', value: 'bar'}
    Severity: Major
    Found in src/index.spec.js and 1 other location - About 1 hr to fix
    src/index.spec.js on lines 109..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(result.record.toObject()).to.eql({
      leader: '',
      fields: [
        {tag: 'FOO', value: 'foo'},
        {tag: 'BAR', value: 'bar'}
    Severity: Major
    Found in src/index.spec.js and 1 other location - About 1 hr to fix
    src/index.spec.js on lines 53..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

          return results;
    Severity: Major
    Found in src/index.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language