NatLibFi/marc-record-validators-melinda

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('Finds the record invalid (spec)', async () => {
      const validator = await validatorFactory(config);
      const result = await validator.validate(recordInvalid);
      expect(result).to.eql({valid: false, message: ['Subfield $100$$4should be excluded']});
    });

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('Finds the record invalid - Ind', async () => {
      const validator = await validatorFactory(configInd);
      const result = await validator.validate(recordIndInvalid);
      expect(result).to.eql({valid: false, message: ['Subfield $500$$2should be excluded']});
    });

• Read up
  Read up

Function mergeOrAddSubfield has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function mergeOrAddSubfield(targetField, candSubfieldData, candFieldPairs880 = []) {

  const candSubfieldAsString = `${candSubfieldData.code} ${candSubfieldData.originalValue}`;

  nvdebug(`   Q: mergeOrAddSubfield '${candSubfieldAsString}'\n      with field '${fieldToString(targetField)}'?`, debugDev);

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $c', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidInd2v1);
        expect(result).to.eql({
          message: ['Field 264 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - 648 Fast, with punc', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalid648FastYes);
        expect(result).to.eql({
          message: ['Field 648 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $d (last of two)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidDDMissing);
        expect(result).to.eql({
          message: ['Field 340 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - Invalid punc $i (":" not valid punc mark, but this is according example...)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidI);
        expect(result).to.eql({
          message: ['Field 538 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $b (mandatory)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidABMissing);
        expect(result).to.eql({
          message: ['Field 340 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - 656 Finnish, with punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalid656FinYes);
        expect(result).to.eql({
          message: ['Field 656 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $a (last)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidAMissingB);
        expect(result).to.eql({
          message: ['Field 340 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - Punc $e (language field, strict)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalid);
        expect(result).to.eql({
          message: ['Field 760 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $i (last before $u)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidMissingI);
        expect(result).to.eql({
          message: ['Field 538 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - 647 Fast, dot at end', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalid647FastEndPunc);
        expect(result).to.eql({
          message: ['Field 647 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $b', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidSimple);
        expect(result).to.eql({
          message: ['Field 880 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $p (last before $y)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordValidMultipleMissingP);
        expect(result).to.eql({
          message: ['Field 242 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - 648 Finnish, with punc', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvali648dFinYes);
        expect(result).to.eql({
          message: ['Field 648 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - 650 !Finnish, without punc (no control)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalid650EngNoControl);
        expect(result).to.eql({
          message: ['Field 650 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $b', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalid);
        expect(result).to.eql({
          message: ['Field 036 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidEndC);
        expect(result).to.eql({
          message: ['Field 260 has invalid ending punctuation'],

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Finds record invalid - No punc $a (only)', async () => {
        const validator = await validatorFactory();
        const result = await validator.validate(recordInvalidA);
        expect(result).to.eql({
          message: ['Field 340 has invalid ending punctuation'],

• Read up
  Read up