Sign upLogin

NatLibFi/melinda-marc-record-utils

View on GitHub
Star

Showing 59 of 59 total issues

Function findAuthorizedPortion has 204 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function findAuthorizedPortion(recordType, recordField) {
    if (recordType === RecordType.AUTH) {
        const isTitlePortion = curry(isTitlePortionSubfield)(recordField);
        const titlePortionStart = recordField.subfields.findIndex(isTitlePortion);
        const hasTitlePortion = titlePortionStart !== -1;
Severity: Major
Found in src/authorized-portion/find-authorized-portion.js - About 1 day to fix

    Consider simplifying this complex logical expression.
    Open

        if (recordType === RecordType.AUTH) {
        const isTitlePortion = curry(isTitlePortionSubfield)(recordField);
        const titlePortionStart = recordField.subfields.findIndex(isTitlePortion);
        const hasTitlePortion = titlePortionStart !== -1;
        const titlePortionEnd = findLastIndex(recordField.subfields, isTitlePortion);
    Severity: Critical
    Found in src/authorized-portion/find-authorized-portion.js - About 7 hrs to fix

      Function createPunctuationFixer has 153 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function createPunctuationFixer(rules, recordType = RecordTypes.BIBLIOGRAPHIC) {
    function punctuateField(field) {
        debug(`Handling field ${field.tag}`);
        debug(`Field contents: ${fieldToString(field)}`);
        const rulesForField = getRulesForField(field.tag);
      Severity: Major
      Found in src/punctuation/create-record-fixer.js - About 6 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                return {
            ind1: recordField.ind1,
            tag: recordField.tag,
            subfields: cloneDeep(recordField.subfields).filter(isAuthorizedSubfield),
            range: {
        Severity: Major
        Found in src/authorized-portion/find-authorized-portion.js and 1 other location - About 6 hrs to fix
        src/authorized-portion/find-authorized-portion.js on lines 155..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                return {
            ind1: recordField.ind1,
            tag: recordField.tag,
            subfields: cloneDeep(recordField.subfields).filter(isAuthorizedSubfield),
            range: {
        Severity: Major
        Found in src/authorized-portion/find-authorized-portion.js and 1 other location - About 6 hrs to fix
        src/authorized-portion/find-authorized-portion.js on lines 273..295

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function createPunctuationFixer has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
        Open

        export default function createPunctuationFixer(rules, recordType = RecordTypes.BIBLIOGRAPHIC) {
    function punctuateField(field) {
        debug(`Handling field ${field.tag}`);
        debug(`Field contents: ${fieldToString(field)}`);
        const rulesForField = getRulesForField(field.tag);
        Severity: Minor
        Found in src/punctuation/create-record-fixer.js - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sortByIndexTerms has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
        Open

        export default function sortByIndexTerms(fieldA, fieldB) {
    const indexTermFields = [
        '600',
        '610',
        '611',
        Severity: Minor
        Found in src/sort/sort-by-index-terms.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sortBy264 has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

        export default function sortBy264(fieldA, fieldB) {
    if (fieldA.tag === '264' && fieldB.tag === '264') {
        if (fieldA.ind2 > fieldB.ind2) {
            return 1;
        }
        Severity: Minor
        Found in src/sort/sort-by-264.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findAuthorizedPortion has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        export default function findAuthorizedPortion(recordType, recordField) {
    if (recordType === RecordType.AUTH) {
        const isTitlePortion = curry(isTitlePortionSubfield)(recordField);
        const titlePortionStart = recordField.subfields.findIndex(isTitlePortion);
        const hasTitlePortion = titlePortionStart !== -1;
        Severity: Minor
        Found in src/authorized-portion/find-authorized-portion.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export default function sortBySID(fieldA, fieldB) {
    if (fieldA.tag === 'SID' && fieldB.tag === 'SID') {
        const sidA = lowerCase(selectFirstValue(fieldA, 'b'));
        const sidB = lowerCase(selectFirstValue(fieldB, 'b'));
        if (sidA > sidB) {
        Severity: Major
        Found in src/sort/sort-by-sid.js and 1 other location - About 3 hrs to fix
        src/sort/sort-by-low.js on lines 32..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export default function sortByLOW(fieldA, fieldB) {
    if (fieldA.tag === 'LOW' && fieldB.tag === 'LOW') {
        const lowA = lowerCase(selectFirstValue(fieldA, 'a'));
        const lowB = lowerCase(selectFirstValue(fieldB, 'a'));
        if (lowA > lowB) {
        Severity: Major
        Found in src/sort/sort-by-low.js and 1 other location - About 3 hrs to fix
        src/sort/sort-by-sid.js on lines 32..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function sortByIndexTerms has 79 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export default function sortByIndexTerms(fieldA, fieldB) {
    const indexTermFields = [
        '600',
        '610',
        '611',
        Severity: Major
        Found in src/sort/sort-by-index-terms.js - About 3 hrs to fix

          Consider simplifying this complex logical expression.
          Open

              if (recordType === RecordType.BIB) {
        const isTitlePortion = curry(isTitlePortionSubfield)(recordField);
        const titlePortionStart = recordField.subfields.findIndex(isTitlePortion);
        const hasTitlePortion = titlePortionStart !== -1;
        const titlePortionEnd = findLastIndex(recordField.subfields, isTitlePortion);
          Severity: Critical
          Found in src/authorized-portion/find-authorized-portion.js - About 3 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            if (type === 'COLON' && !/:$/.test(preceedingSubfield.value)) {
                    const nextValue = preceedingSubfield.value + ' :';
                    debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
                    preceedingSubfield.value = nextValue;
                }
            Severity: Major
            Found in src/punctuation/create-record-fixer.js and 2 other locations - About 2 hrs to fix
            src/punctuation/create-record-fixer.js on lines 142..146
            src/punctuation/create-record-fixer.js on lines 211..215

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            if (type === 'SEMICOLON' && !/;$/.test(preceedingSubfield.value)) {
                    const nextValue = preceedingSubfield.value + ' ;';
                    debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
                    preceedingSubfield.value = nextValue;
                }
            Severity: Major
            Found in src/punctuation/create-record-fixer.js and 2 other locations - About 2 hrs to fix
            src/punctuation/create-record-fixer.js on lines 142..146
            src/punctuation/create-record-fixer.js on lines 217..221

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (punctType === 'PERIOD' && !/\.$/.test(preceedingSubfield.value)) {
                const nextValue = preceedingSubfield.value + '.';
                debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
                preceedingSubfield.value = nextValue;
            }
            Severity: Major
            Found in src/punctuation/create-record-fixer.js and 2 other locations - About 2 hrs to fix
            src/punctuation/create-record-fixer.js on lines 211..215
            src/punctuation/create-record-fixer.js on lines 217..221

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (punctType === 'COND_COMMA') {
            if (!/[-,]$/.test(preceedingSubfield.value)) {
                const nextValue = preceedingSubfield.value + ',';
                debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
                preceedingSubfield.value = nextValue;
            Severity: Major
            Found in src/punctuation/create-record-fixer.js and 1 other location - About 2 hrs to fix
            src/punctuation/create-record-fixer.js on lines 150..156

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (!/,$/.test(preceedingSubfield.value)) {
                if (!/^[[(]/.test(currentSubfield.value)) {
                    const nextValue = preceedingSubfield.value + ',';
                    debug(`Updated subfield ${preceedingSubfield.code} from '${preceedingSubfield.value}' to '${nextValue}'`);
                    preceedingSubfield.value = nextValue;
            Severity: Major
            Found in src/punctuation/create-record-fixer.js and 1 other location - About 2 hrs to fix
            src/punctuation/create-record-fixer.js on lines 159..165

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function punctuateField has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function punctuateField(field) {
        debug(`Handling field ${field.tag}`);
        debug(`Field contents: ${fieldToString(field)}`);
        const rulesForField = getRulesForField(field.tag);
        if (rulesForField.length === 0) {
            Severity: Minor
            Found in src/punctuation/create-record-fixer.js - About 1 hr to fix

              Function sortBy264 has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export default function sortBy264(fieldA, fieldB) {
    if (fieldA.tag === '264' && fieldB.tag === '264') {
        if (fieldA.ind2 > fieldB.ind2) {
            return 1;
        }
              Severity: Minor
              Found in src/sort/sort-by-264.js - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language