Sign upLogin

NatLibFi/record-loader-melinda

View on GitHub
Star

Showing 46 of 46 total issues

Function factory has 245 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(Promise, Object, MelindaClient, MarcRecord, recordStoreFactory) {

  'use strict';

  function normalizeRecordId(id)
Severity: Major
Found in lib/record-store/melinda.js - About 1 day to fix

    Function factory has 198 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function factory(Promise, Object, MarcRecord, mergeObjects, hookFactory)
{
    
    'use strict';
    Severity: Major
    Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 7 hrs to fix

      Function run has 176 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  run: function(records)
            {
                return record_store.read({
                    
                    idList: [records[0].melindaHostId],
      Severity: Major
      Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 7 hrs to fix

        Function normalizeMatches has 145 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                            function normalizeMatches(records)
                    {
                        
                        function hasFailures(records)
                        {
        Severity: Major
        Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 5 hrs to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {
  
  'use strict';
  
  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/processors/preprocess/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/hooks/related-records-matched/hostcomp.js on lines 30..52
          lib/record-store/melinda.js on lines 30..52
          lib/result-formatter/melinda.js on lines 30..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {
    
    'use strict';
    
    if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js and 3 other locations - About 3 hrs to fix
          lib/processors/preprocess/melinda.js on lines 30..52
          lib/record-store/melinda.js on lines 30..52
          lib/result-formatter/melinda.js on lines 30..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/record-store/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/hooks/related-records-matched/hostcomp.js on lines 30..52
          lib/processors/preprocess/melinda.js on lines 30..52
          lib/result-formatter/melinda.js on lines 30..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/result-formatter/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/hooks/related-records-matched/hostcomp.js on lines 30..52
          lib/processors/preprocess/melinda.js on lines 30..52
          lib/record-store/melinda.js on lines 30..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/hooks/related-records-retrieved/hostcomp.js and 1 other location - About 3 hrs to fix
          lib/hostcomp/result-formatter/melinda.js on lines 30..50

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/result-formatter/melinda.js and 1 other location - About 3 hrs to fix
          lib/hostcomp/hooks/related-records-retrieved/hostcomp.js on lines 30..50

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/processors/filter/melinda.js and 1 other location - About 3 hrs to fix
          lib/hostcomp/record-set/hostcomp.js on lines 30..48

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/record-set/hostcomp.js and 1 other location - About 3 hrs to fix
          lib/processors/filter/melinda.js on lines 30..48

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/processors/preprocess/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/processors/filter/melinda.js on lines 30..46
          lib/hostcomp/processors/match/melinda.js on lines 30..46
          lib/hostcomp/processors/merge/melinda.js on lines 30..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/processors/filter/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/processors/match/melinda.js on lines 30..46
          lib/hostcomp/processors/merge/melinda.js on lines 30..46
          lib/hostcomp/processors/preprocess/melinda.js on lines 30..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/processors/match/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/processors/filter/melinda.js on lines 30..46
          lib/hostcomp/processors/merge/melinda.js on lines 30..46
          lib/hostcomp/processors/preprocess/melinda.js on lines 30..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
          Severity: Major
          Found in lib/hostcomp/processors/merge/melinda.js and 3 other locations - About 3 hrs to fix
          lib/hostcomp/processors/filter/melinda.js on lines 30..46
          lib/hostcomp/processors/match/melinda.js on lines 30..46
          lib/hostcomp/processors/preprocess/melinda.js on lines 30..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function factory has 74 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function factory(Promise, Object, MarcRecord, hookFactory)
{
  
  'use strict';
          Severity: Major
          Found in lib/hostcomp/hooks/related-records-retrieved/hostcomp.js - About 2 hrs to fix

            Function processBundles has 74 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function processBundles(filenames, result) {
  var data;
  var filename = filenames.shift();

  if (filename) {
            Severity: Major
            Found in bin/run-host-components-merge.js - About 2 hrs to fix

              Function factory has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function factory(Promise, Object, validateFactory, MarcRecord, rankFactory, mergeFactory, processorFactory) {

  'use strict';

  var DEFAULT_OPTIONS = {
              Severity: Major
              Found in lib/processors/merge/melinda.js - About 2 hrs to fix

                Function factory has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function factory(Object, Promise, MarcRecord, marc_record_converters, resultFormatterFactory)
{
  
  'use strict';
                Severity: Major
                Found in lib/result-formatter/melinda.js - About 2 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language