Sign upLogin

NatLibFi/record-loader-melinda

View on GitHub
Star
lib/hostcomp/hooks/related-records-matched/hostcomp.js

Summary

Maintainability
F
3 days
Test Coverage

Function factory has 198 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(Promise, Object, MarcRecord, mergeObjects, hookFactory)
{
    
    'use strict';
Severity: Major
Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 7 hrs to fix

    Function run has 176 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                run: function(records)
            {
                return record_store.read({
                    
                    idList: [records[0].melindaHostId],
    Severity: Major
    Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 7 hrs to fix

      Function normalizeMatches has 145 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          function normalizeMatches(records)
                    {
                        
                        function hasFailures(records)
                        {
      Severity: Major
      Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 5 hrs to fix

        Function findMissingByIndex has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                                function findMissingByIndex(record, index, records)
                        {
                            
                            function getSurroundingRecords()
                            {
        Severity: Minor
        Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 1 hr to fix

          Function factory has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function factory(Promise, Object, MarcRecord, mergeObjects, hookFactory)
          Severity: Minor
          Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js - About 35 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            (function (root, factory) {
    
    'use strict';
    
    if (typeof define === 'function' && define.amd) {
            Severity: Major
            Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js and 3 other locations - About 3 hrs to fix
            lib/processors/preprocess/melinda.js on lines 30..52
            lib/record-store/melinda.js on lines 30..52
            lib/result-formatter/melinda.js on lines 30..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        records = records.map(function(record) {
                                return Object.assign(record, record.matchedRecords.length > 1 ? {
                                    failed: true,
                                    message: 'Multiple matches not allowed'
                                } : {});
            Severity: Major
            Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js and 1 other location - About 1 hr to fix
            lib/hostcomp/hooks/related-records-matched/hostcomp.js on lines 255..260

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        records = records.map(function(record) {
                                return Object.assign(record, record.matchedRecords.length === 0 ? {
                                    failed: true,
                                    message: 'Records without matches not allowed'
                                } : {});
            Severity: Major
            Found in lib/hostcomp/hooks/related-records-matched/hostcomp.js and 1 other location - About 1 hr to fix
            lib/hostcomp/hooks/related-records-matched/hostcomp.js on lines 148..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status