Sign upLogin

NatLibFi/record-loader-melinda

View on GitHub
Star
lib/record-store/melinda.js

Summary

Maintainability
D
2 days
Test Coverage

Function factory has 245 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(Promise, Object, MelindaClient, MarcRecord, recordStoreFactory) {

  'use strict';

  function normalizeRecordId(id)
Severity: Major
Found in lib/record-store/melinda.js - About 1 day to fix

    File melinda.js has 268 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 *
 * @licstart  The following is the entire license notice for the JavaScript code in this file. 
 *
 * Melinda-related modules for recordLoader
    Severity: Minor
    Found in lib/record-store/melinda.js - About 2 hrs to fix

      Function read has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            read: function(query)
      {

        var fn_get_records, fn_get_records_cache;
      Severity: Minor
      Found in lib/record-store/melinda.js - About 2 hrs to fix

        Function update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              update: function(query, record_data)
      {

        function process(list, results)
        {
        Severity: Minor
        Found in lib/record-store/melinda.js - About 1 hr to fix

          Function pump has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function pump(list, results)
        {

          var id = list.shift();
          Severity: Minor
          Found in lib/record-store/melinda.js - About 1 hr to fix

            Function factory has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function factory(Promise, Object, MelindaClient, MarcRecord, recordStoreFactory) {
            Severity: Minor
            Found in lib/record-store/melinda.js - About 35 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

              (function (root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
              Severity: Major
              Found in lib/record-store/melinda.js and 3 other locations - About 3 hrs to fix
              lib/hostcomp/hooks/related-records-matched/hostcomp.js on lines 30..52
              lib/processors/preprocess/melinda.js on lines 30..52
              lib/result-formatter/melinda.js on lines 30..52

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 113.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status