NatLibFi/record-loader

View on GitHub

Showing 18 of 20 total issues

Function factory has 355 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(Promise, Object, Array, shim_array, utils, loggerFactory, resultFormatterFactory, recordStoreFactory, relatedRecordsRetrievedHookFactory, relatedRecordsMatchedHookFactory)
{

  'use strict';

Severity: Major
Found in lib/create-main.js - About 1 day to fix

    Function exports has 348 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var exports = function(modules, script_processor)
        {
          
          /**
           * @constant
    Severity: Major
    Found in lib/create-main.js - About 1 day to fix

      Function processRecordSet has 169 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  function processRecordSet(total_results)
                  {
                    
                    var fn_related_records_pipeline;
      
      
      Severity: Major
      Found in lib/create-main.js - About 6 hrs to fix

        Function factory has 160 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function factory(Promise, Object, shim_array, utils, loggerFactory, recordStoreFactory, filterProcessorFactory, preprocessProcessorFactory, matchProcessorFactory, mergeProcessorFactory, loadProcessorFactory)
        {
        
          'use strict';
        
        
        Severity: Major
        Found in lib/create-processor-factory.js - About 6 hrs to fix

          Function exports has 136 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var exports = function(modules)
              {
                
                var modules_run, loggers, initialized;
                
          Severity: Major
          Found in lib/create-processor-factory.js - About 5 hrs to fix

            File create-main.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /**
             *
             * @licstart  The following is the entire license notice for the JavaScript code in this file. 
             *
             * Load records into a data store while filtering, preprocessing, matching & merging them in the process
            Severity: Minor
            Found in lib/create-main.js - About 5 hrs to fix

              Consider simplifying this complex logical expression.
              Open

                    if (!modules.hasOwnProperty('recordSet')) {
                      throw new Error('Record set module is mandatory');
                    } else {
                      /**
                       * @callback loadRecords
              Severity: Critical
              Found in lib/create-main.js - About 4 hrs to fix

                Function factory has 100 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function factory(Object)
                {
                
                  'use strict';
                
                
                Severity: Major
                Found in lib/utils.js - About 4 hrs to fix

                  Function processRecord has 98 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        function processRecord(state, target_step, options, exchange_data)
                        {
                          var steps = utils.PROCESSING_STEPS.slice(
                            state.step ? utils.PROCESSING_STEPS.indexOf(state.step) + 1 : 0,
                            utils.PROCESSING_STEPS.indexOf(target_step) + 1
                  Severity: Major
                  Found in lib/create-processor-factory.js - About 3 hrs to fix

                    Function createFinalResults has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                                function createFinalResults(result_sets)
                                {
                                  
                                  var results, final_results;
                    
                    
                    Severity: Major
                    Found in lib/create-main.js - About 3 hrs to fix

                      Function factory has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function factory(Object)
                      {
                      
                        'use strict';
                      
                      
                      Severity: Minor
                      Found in lib/utils.js - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function buildRelatedRecordsPipeline has 69 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                    function buildRelatedRecordsPipeline(target)
                                    {
                      
                                      var target_index = utils.PROCESSING_STEPS.indexOf(target),
                                      match_index = utils.PROCESSING_STEPS.indexOf('match');
                      Severity: Major
                      Found in lib/create-main.js - About 2 hrs to fix

                        Function iterate has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                function iterate(steps, state)
                                {
                                  var fn_run_processor,
                                  step = steps.shift();
                        
                        
                        Severity: Minor
                        Found in lib/create-processor-factory.js - About 1 hr to fix

                          Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          module.exports = function(config) {
                            config.set({
                              singleRun: true,
                              frameworks: ['mocha', 'requirejs'],
                              browsers: ['PhantomJS'],
                          Severity: Minor
                          Found in karma.conf.js - About 1 hr to fix

                            Function factory has 11 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            function factory(Promise, Object, shim_array, utils, loggerFactory, recordStoreFactory, filterProcessorFactory, preprocessProcessorFactory, matchProcessorFactory, mergeProcessorFactory, loadProcessorFactory)
                            Severity: Major
                            Found in lib/create-processor-factory.js - About 1 hr to fix

                              Function factory has 10 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              function factory(Promise, Object, Array, shim_array, utils, loggerFactory, resultFormatterFactory, recordStoreFactory, relatedRecordsRetrievedHookFactory, relatedRecordsMatchedHookFactory)
                              Severity: Major
                              Found in lib/create-main.js - About 1 hr to fix

                                Function initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                      function initialize(modules_run, options)
                                      {
                                        if (modules_run && loggers) {
                                          return {
                                            modules: modules_run,
                                Severity: Minor
                                Found in lib/create-processor-factory.js - About 1 hr to fix

                                  Function process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                                  function process(records, target)
                                                  {
                                                    return new Promise(function(resolveCallback, rejectCallback) {
                                  
                                                      var results = [];
                                  Severity: Minor
                                  Found in lib/create-main.js - About 1 hr to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language