NationalGenomicsInfrastructure/ngi_pipeline

View on GitHub
ngi_pipeline/engines/sarek/exceptions.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, projectid, sampleid, libprepid, seqrunid, message=None, reason=None):
Severity: Minor
Found in ngi_pipeline/engines/sarek/exceptions.py - About 45 mins to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, projectid, sampleid, libprepid, seqrunid, status, reason=None):
    Severity: Minor
    Found in ngi_pipeline/engines/sarek/exceptions.py - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      class ReferenceGenomeNotRecognized(Exception):
      
          def __init__(self, genome_name):
              super(ReferenceGenomeNotRecognized, self).__init__(
                  "reference genome '{}' not recognized".format(genome_name))
      Severity: Major
      Found in ngi_pipeline/engines/sarek/exceptions.py and 2 other locations - About 1 hr to fix
      ngi_pipeline/engines/sarek/exceptions.py on lines 7..12
      ngi_pipeline/engines/sarek/exceptions.py on lines 151..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      class BestPracticeAnalysisNotRecognized(SarekException):
      
          def __init__(self, best_practice_analysis):
              super(BestPracticeAnalysisNotRecognized, self).__init__(
                  "best-practice-analysis '{}' not recognized".format(best_practice_analysis))
      Severity: Major
      Found in ngi_pipeline/engines/sarek/exceptions.py and 2 other locations - About 1 hr to fix
      ngi_pipeline/engines/sarek/exceptions.py on lines 15..20
      ngi_pipeline/engines/sarek/exceptions.py on lines 151..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      class AlignmentStatusForAnalysisStatusNotFoundError(Exception):
      
          def __init__(self, analysis_status):
              super(AlignmentStatusForAnalysisStatusNotFoundError, self).__init__(
                  "Charon alignment status corresponding to analysis status {} not found".format(analysis_status))
      Severity: Major
      Found in ngi_pipeline/engines/sarek/exceptions.py and 2 other locations - About 1 hr to fix
      ngi_pipeline/engines/sarek/exceptions.py on lines 7..12
      ngi_pipeline/engines/sarek/exceptions.py on lines 15..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status