Sign upLogin

Nekmo/djangocms-comments

View on GitHub
Star

Showing 17 of 17 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def make_published(self, request, queryset):
        def action(comment):
            comment.moderated = ''
            comment.published = True
        self._make_base(request, queryset.exclude(moderated='', published=True), action,
Severity: Major
Found in djangocms_comments/admin.py and 1 other location - About 2 hrs to fix
djangocms_comments/admin.py on lines 283..288

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def make_soft_deleted(self, request, queryset):
        def action(comment):
            comment.moderated = 'deleted'
            comment.published = True
        self._make_base(request, queryset.exclude(moderated='deleted', published=True), action,
Severity: Major
Found in djangocms_comments/admin.py and 1 other location - About 2 hrs to fix
djangocms_comments/admin.py on lines 291..296

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File admin.py has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import django
from django.contrib import admin
from django.contrib.admin.utils import unquote
from django.db.models import TextField
from django.forms import ModelForm, ChoiceField, CharField, BooleanField
Severity: Minor
Found in djangocms_comments/admin.py - About 2 hrs to fix

    Function save_model has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def save_model(self, request, obj, form, change):
        if obj.pk and form.cleaned_data['body'] != self.model.objects.get(pk=obj.pk).body:
            self.message_user(request, _('The comment has been marked as edited.'))
            obj.moderated_by = request.user
            obj.moderated = 'edited'
    Severity: Minor
    Found in djangocms_comments/admin.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function report has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def report(self, is_spam, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
    Severity: Major
    Found in djangocms_comments/spam.py - About 1 hr to fix

      Function report has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def report(self, is_spam, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
      Severity: Major
      Found in djangocms_comments/spam.py - About 1 hr to fix

        Function report has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def report(self, is_spam, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
        Severity: Major
        Found in djangocms_comments/spam.py - About 1 hr to fix

          Function check has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def check(self, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
          Severity: Major
          Found in djangocms_comments/spam.py - About 1 hr to fix

            Function check has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def check(self, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
            Severity: Major
            Found in djangocms_comments/spam.py - About 1 hr to fix

              Function check has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def check(self, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
              Severity: Major
              Found in djangocms_comments/spam.py - About 1 hr to fix

                Function send_comment has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def send_comment(self, author=None, body='', data=None, ajax=True, is_test=True, ip=None, obj=None):
                Severity: Major
                Found in djangocms_comments/tests/base.py - About 50 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          with self.assertRaises(Comment.DoesNotExist):
            Comment.objects.get(config=self.config, body=body,**self.get_page_ct_id())
                  Severity: Minor
                  Found in djangocms_comments/tests/test_comment_box.py and 1 other location - About 50 mins to fix
                  djangocms_comments/tests/test_comment_box.py on lines 97..98

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 36.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          with self.assertRaises(Comment.DoesNotExist):
            Comment.objects.get(config=self.config, body=body, **self.get_page_ct_id())
                  Severity: Minor
                  Found in djangocms_comments/tests/test_comment_box.py and 1 other location - About 50 mins to fix
                  djangocms_comments/tests/test_comment_box.py on lines 90..91

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 36.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function get_request has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def get_request(self, user, method='get', data=None, url='/demo', is_test=True, ip=None):
                  Severity: Minor
                  Found in djangocms_comments/tests/base.py - About 45 mins to fix

                    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def __init__(self, name, value, attrs, choice, index):
                    Severity: Minor
                    Found in djangocms_comments/fields.py - About 35 mins to fix

                      Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def save(self, commit=True, author=None):
        author = author or self.request.user
        user_agent = self.request.META.get('HTTP_USER_AGENT', 'unknown')
        referrer = self.request.META.get('HTTP_REFERER', '')
        user_ip = get_client_ip(self.request)
                      Severity: Minor
                      Found in djangocms_comments/forms.py - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this function.
                      Open

                                  return queryset.filter(moderated='deleted', published=True)
                      Severity: Major
                      Found in djangocms_comments/admin.py - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language