Showing 13 of 17 total issues
File admin.py
has 259 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
import django
from django.contrib import admin
from django.contrib.admin.utils import unquote
from django.db.models import TextField
from django.forms import ModelForm, ChoiceField, CharField, BooleanField
Function save_model
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
def save_model(self, request, obj, form, change):
if obj.pk and form.cleaned_data['body'] != self.model.objects.get(pk=obj.pk).body:
self.message_user(request, _('The comment has been marked as edited.'))
obj.moderated_by = request.user
obj.moderated = 'edited'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function report
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def report(self, is_spam, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
Function report
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def report(self, is_spam, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
Function report
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def report(self, is_spam, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
Function check
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def check(self, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
Function check
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def check(self, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
Function check
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def check(self, author, email, body, user_ip, user_agent, url=None, referrer='unknown', blog_domain=None):
Function send_comment
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def send_comment(self, author=None, body='', data=None, ajax=True, is_test=True, ip=None, obj=None):
Function get_request
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def get_request(self, user, method='get', data=None, url='/demo', is_test=True, ip=None):
Function __init__
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def __init__(self, name, value, attrs, choice, index):
Function save
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def save(self, commit=True, author=None):
author = author or self.request.user
user_agent = self.request.META.get('HTTP_USER_AGENT', 'unknown')
referrer = self.request.META.get('HTTP_REFERER', '')
user_ip = get_client_ip(self.request)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
Open
return queryset.filter(moderated='deleted', published=True)