Sign upLogin

Nekmo/os3

View on GitHub
Star

Showing 28 of 28 total issues

Function find_package_data has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

def find_package_data(where='.', package='',
                      exclude=standard_exclude,
                      exclude_directories=standard_exclude_directories,
                      only_in_packages=True,
                      show_ignored=False):
Severity: Minor
Found in setup.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                for pattern in exclude:
                    if (fnmatchcase(name, pattern)
                        or fn.lower() == pattern.lower()):
                        bad_name = True
                        if show_ignored:
Severity: Major
Found in setup.py and 1 other location - About 3 hrs to fix
setup.py on lines 123..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                for pattern in exclude_directories:
                    if (fnmatchcase(name, pattern)
                        or fn.lower() == pattern.lower()):
                        bad_name = True
                        if show_ignored:
Severity: Major
Found in setup.py and 1 other location - About 3 hrs to fix
setup.py on lines 147..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Os3List has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class Os3List(Os3Item):
    default_format = 'list'
    _tuple_filters = None
    _dict_filters = None
    _sort = None # []
Severity: Minor
Found in os3/core/list.py - About 2 hrs to fix

    Entry has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Entry(Os3Item):
    _stat = None
    _type = None
    path = ''
    root = None
    Severity: Minor
    Found in os3/fs/entry.py - About 2 hrs to fix

      Function deep_scandir has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      def deep_scandir(path, deep=False, cls=None, filter=None, traverse_filter=None, exceptions=None):
    filter = filter or (lambda x: True)
    traverse_filter = traverse_filter or (lambda x: True)

    for item in scandir(path, return_value=iter(()), exceptions=exceptions):
      Severity: Minor
      Found in os3/utils/nodes.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function pprint_list has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      def pprint_list(input_list):
    # http://stackoverflow.com/questions/25026556/output-list-like-ls
    (term_width, term_height) = get_terminal_size()
    if len( str(input_list) ) <= term_width:
        return '    '.join(input_list)
      Severity: Minor
      Found in os3/utils/console.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function readlines has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def readlines(self, n=None, mode='r', buffering=-1, encoding=None, errors=None, newline=None, closefd=True,
      Severity: Major
      Found in os3/fs/file.py - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @property
    def mtime(self):
        stat = self.stat()
        if not stat:
            return
        Severity: Major
        Found in os3/fs/entry.py and 1 other location - About 1 hr to fix
        os3/fs/entry.py on lines 71..76

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @property
    def atime(self):
        stat = self.stat()
        if not stat:
            return
        Severity: Major
        Found in os3/fs/entry.py and 1 other location - About 1 hr to fix
        os3/fs/entry.py on lines 64..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function bak_target_decorator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        def bak_target_decorator(fn):
    def decorator(src, dst=None, **kwargs):
        src, dst = Entry(src), Entry(dst) if dst else dst
        if dst and os.path.islink(dst.path) and os.path.realpath(dst.path) == os.path.realpath(src.path):
            return
        Severity: Minor
        Found in os3/fs/utils.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function readline has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def readline(self, mode='r', buffering=-1, encoding=None, errors=None, newline=None, closefd=True, opener=None,
        Severity: Major
        Found in os3/fs/file.py - About 1 hr to fix

          Function read has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def read(self, n=None, mode=None, buffering=-1, encoding=None, errors=None, newline=None, closefd=True,
          Severity: Major
          Found in os3/fs/file.py - About 1 hr to fix

            Function write has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def write(self, data, mode=None, buffering=-1, encoding=None, errors=None, newline=None, closefd=True, opener=None):
            Severity: Major
            Found in os3/fs/file.py - About 1 hr to fix

              Function __new__ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def __new__(cls, *args, **kwargs):
        classes = cls.get_classes()
        Dir, File = classes['Dir'], classes['File']
        if cls != (cls.entry_class or Entry) or not args:
            return Os3Item.__new__(cls)
              Severity: Minor
              Found in os3/fs/entry.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function items_iterator has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              def items_iterator(items, depth=None):
    for item in items:
        yield item
        if not isinstance(item, DataTree) or not depth:
            continue
              Severity: Minor
              Found in os3/data/list.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _get_open has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _get_open(self, mode='r', buffering=-1, encoding=None, errors=None, newline=None, closefd=True, opener=None):
              Severity: Major
              Found in os3/fs/file.py - About 50 mins to fix

                Function open has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def open(self, mode='r', buffering=-1, encoding=None, errors=None, newline=None, closefd=True, opener=None):
                Severity: Major
                Found in os3/fs/file.py - About 50 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if (fnmatchcase(name, pattern)
                        or fn.lower() == pattern.lower()):
                        bad_name = True
                        if show_ignored:
                            sys.stderr.write(
                  Severity: Major
                  Found in setup.py - About 45 mins to fix

                    Function deep_scandir has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def deep_scandir(path, deep=False, cls=None, filter=None, traverse_filter=None, exceptions=None):
                    Severity: Minor
                    Found in os3/utils/nodes.py - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language