Sign upLogin

Nephos/NephosRubyServer

View on GitHub
Star
lib/nephos-server/router/load.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method check_keys! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def self.check_keys! what
      raise InvalidRouteUrl, "Missing URL" unless what.keys.include? :url
      if what.keys.include? :to
        match = what[:to].match(/(?<controller>\w+)\#(?<method>\w+)/)
        raise InvalidRouteTo, "Invalid Controller#Method" unless match
Severity: Minor
Found in lib/nephos-server/router/load.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_params! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.add_params!(what)
      params = what[:url].split('/').map do |p|
        p.match(/:\w+/) ? {p: "[^\/]+", name: p} : {p: Regexp.escape(p), name: nil}
      end
      url = params.map{|e| e[:p]}.join("/+")
Severity: Minor
Found in lib/nephos-server/router/load.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status