Sign upLogin

NeroReflex/Gishiki

View on GitHub
Star

Showing 176 of 176 total issues

Function parseStandardConnectionQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseStandardConnectionQuery($connection)
    {
        /*
         * split the string into an array like
         *     0 => 'user:pass',
Severity: Minor
Found in src/Database/Adapters/Utils/ConnectionParser/ConnectionParserTrait.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function serialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function serialize($format = self::JSON)
    {
        if (!is_integer($format)) {
            throw new \InvalidArgumentException('Invalid serialization format');
        }
Severity: Minor
Found in src/Algorithms/Collections/SerializableCollection.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($algorithm = Algorithm::BCRYPT)
    {
        //check if the hashing algorithm is supported
        if (strcmp($algorithm, Algorithm::BCRYPT) == 0) {
            $this->algorithm = $algorithm;
Severity: Minor
Found in src/Security/Hashing/Hasher.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused private methods such as 'export'.
Open

    private function export()
    {
        $export = [
            'limit' => $this->limit,
            'skip' => $this->skip,
Severity: Minor
Found in src/Database/Runtime/ResultModifier.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

The method fromMixed uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $domElement->appendChild($this->createTextNode($mixed));
        }
Severity: Minor
Found in src/Algorithms/XmlDomConstructor.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$fieldName'.
Open

    private static function loadField(Table &$table, array $fieldDefinition, $fieldName = null)
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordStructureTrait.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$controllerArgs'.
Open

    public function __invoke(RequestInterface &$request, ResponseInterface &$response, GenericCollection &$arguments, $controllerArgs = [], Application $app = null)
Severity: Minor
Found in src/Core/Router/Route.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method parseStandardConnectionQuery() has an NPath complexity of 432. The configured NPath complexity threshold is 200.
Open

    protected function parseStandardConnectionQuery($connection)
    {
        /*
         * split the string into an array like
         *     0 => 'user:pass',
Severity: Minor
Found in src/Database/Adapters/Utils/ConnectionParser/ConnectionParserTrait.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method definedAs() has an NPath complexity of 289. The configured NPath complexity threshold is 200.
Open

    public function &definedAs(array $columns) : SQLWrapperInterface
    {
        $this->appendToQuery('(');

        $first = true;
Severity: Minor
Found in src/Database/Adapters/Utils/SQLGenerator/PostgreSQLWrapper.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused local variables such as '$filterNumber'.
Open

        foreach ($this->filters[$key] as $filterNumber => $filter) {
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordSerializationTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$value'.
Open

        return (($value = getenv($key)) !== false);
Severity: Minor
Found in src/Core/Environment.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$fieldName'.
Open

        foreach (static::$structure['fields'] as $fieldName => &$fieldDefinition) {
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordStructureTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method fromMixed uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $node = $this->createElement($index);
                    $domElement->appendChild($node);
                }
Severity: Minor
Found in src/Algorithms/XmlDomConstructor.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getPDOConnection() has an NPath complexity of 243. The configured NPath complexity threshold is 200.
Open

    public function getPDOConnection() : array
    {
        $query = $this->getPDODriverName() . ':';

        $query .= ((is_string($this->host)) && (strlen($this->host) > 0)) ?
Severity: Minor
Found in src/Database/Adapters/Utils/ConnectionParser/ConnectionParserTrait.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method definedAs() has an NPath complexity of 289. The configured NPath complexity threshold is 200.
Open

    public function &definedAs(array $columns) : SQLWrapperInterface
    {
        $this->appendToQuery('(');

        $first = true;
Severity: Minor
Found in src/Database/Adapters/Utils/SQLGenerator/SQLiteWrapper.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method __construct() has an NPath complexity of 6400. The configured NPath complexity threshold is 200.
Open

    public function __construct(array $options)
    {
        $this->route = [
            "plugins" => [
                "deserializer" => DeserializerPlugin::class,
Severity: Minor
Found in src/Core/Router/Route.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method definedAs() has an NPath complexity of 578. The configured NPath complexity threshold is 200.
Open

    public function &definedAs(array $columns) : SQLWrapperInterface
    {
        //mysql wants PRIMARY KEY(...) after column definitions
        $primaryKeyName = '';
Severity: Minor
Found in src/Database/Adapters/Utils/SQLGenerator/MySQLWrapper.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused private methods such as 'export'.
Open

    private function export()
    {
        $export = [
            'historic' => $this->historic,
            'criteria' => $this->criteria,
Severity: Minor
Found in src/Database/Runtime/SelectionCriteria.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

The method fromMixed uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $node = $this->createElement($domElement->tagName);
                        $domElement->parentNode->appendChild($node);
                    }
Severity: Minor
Found in src/Algorithms/XmlDomConstructor.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method definedAs() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
Open

    public function &definedAs(array $columns) : SQLWrapperInterface
    {
        $this->appendToQuery('(');

        $first = true;
Severity: Minor
Found in src/Database/Adapters/Utils/SQLGenerator/SQLiteWrapper.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Severity
Category
Status
Source
Language