Sign upLogin

NeroReflex/Gishiki

View on GitHub
Star
src/Algorithms/Collections/GenericCollection.php

Summary

Maintainability
A
0 mins
Test Coverage

The class GenericCollection has 15 public methods. Consider refactoring GenericCollection to keep number of public methods under 10.
Open

class GenericCollection implements CollectionInterface, \IteratorAggregate
{
    /**
     * @var array The source data.
     */
Severity: Minor
Found in src/Algorithms/Collections/GenericCollection.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Missing class import via use statement (line '45', column '23').
Open

            throw new \InvalidArgumentException('The collection of properties and nested data must be expressed as an array: '.gettype($items).' given');
Severity: Minor
Found in src/Algorithms/Collections/GenericCollection.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '227', column '20').
Open

        return new \ArrayIterator($this->data);
Severity: Minor
Found in src/Algorithms/Collections/GenericCollection.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status