NeroReflex/Gishiki

View on GitHub
src/Core/MVC/Model/ActiveRecordSerializationTrait.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method initTransitionSchema has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function initTransitionSchema()
    {
        //table must have been already correctly parsed, so I know data is well-formed
        if (!ActiveRecordTables::isRegistered(static::class)) {
            throw new ActiveRecordException("Table definition for the current ActiveRecord object is missing.", 300);
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordSerializationTrait.php - About 1 hr to fix

    Function initTransitionSchema has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function initTransitionSchema()
        {
            //table must have been already correctly parsed, so I know data is well-formed
            if (!ActiveRecordTables::isRegistered(static::class)) {
                throw new ActiveRecordException("Table definition for the current ActiveRecord object is missing.", 300);
    Severity: Minor
    Found in src/Core/MVC/Model/ActiveRecordSerializationTrait.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method initTransitionSchema() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
    Open

        private function initTransitionSchema()
        {
            //table must have been already correctly parsed, so I know data is well-formed
            if (!ActiveRecordTables::isRegistered(static::class)) {
                throw new ActiveRecordException("Table definition for the current ActiveRecord object is missing.", 300);

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using undefined variables such as '::$structure' which will lead to PHP notices.
    Open

            foreach (static::$structure['fields'] as $fieldName => &$fieldDefinition) {

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid unused local variables such as '$filterNumber'.
    Open

            foreach ($this->filters[$key] as $filterNumber => $filter) {

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    There are no issues that match your filters.

    Category
    Status