Sign upLogin

NeroReflex/Gishiki

View on GitHub
Star
src/Core/Router/MatchableRouteTrait.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function matchCheck has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    protected static function matchCheck($uriSplit, $urlSplit, array &$params) : bool
    {
        $result = false;

        if ((strlen($uriSplit) >= 7) && ($uriSplit[0] == '{') && ($uriSplit[strlen($uriSplit) - 1] == '}')) {
Severity: Minor
Found in src/Core/Router/MatchableRouteTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method matchCheck has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static function matchCheck($uriSplit, $urlSplit, array &$params) : bool
    {
        $result = false;

        if ((strlen($uriSplit) >= 7) && ($uriSplit[0] == '{') && ($uriSplit[strlen($uriSplit) - 1] == '}')) {
Severity: Minor
Found in src/Core/Router/MatchableRouteTrait.php - About 1 hr to fix

    Method matchURI has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function matchURI($uri, $url, array &$matchedExpr, array &$matchedGet) : bool
    {
        if (!is_string($url)) {
            throw new \InvalidArgumentException("The URL must be given as a valid string");
        }
    Severity: Minor
    Found in src/Core/Router/MatchableRouteTrait.php - About 1 hr to fix

      Function matchURI has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function matchURI($uri, $url, array &$matchedExpr, array &$matchedGet) : bool
    {
        if (!is_string($url)) {
            throw new \InvalidArgumentException("The URL must be given as a valid string");
        }
      Severity: Minor
      Found in src/Core/Router/MatchableRouteTrait.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function paramCheck has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function paramCheck($urlSplit, $type) : bool
    {
        if ((!is_int($type)) || ($type < 0) || ($type > 4)) {
            throw new RouterException("Invalid parameter type", 100);
        }
      Severity: Minor
      Found in src/Core/Router/MatchableRouteTrait.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method matchCheck() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
      Open

          protected static function matchCheck($uriSplit, $urlSplit, array &$params) : bool
    {
        $result = false;

        if ((strlen($uriSplit) >= 7) && ($uriSplit[0] == '{') && ($uriSplit[strlen($uriSplit) - 1] == '}')) {
      Severity: Minor
      Found in src/Core/Router/MatchableRouteTrait.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method matchURI() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          public static function matchURI($uri, $url, array &$matchedExpr, array &$matchedGet) : bool
    {
        if (!is_string($url)) {
            throw new \InvalidArgumentException("The URL must be given as a valid string");
        }
      Severity: Minor
      Found in src/Core/Router/MatchableRouteTrait.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '185', column '23').
      Open

                  throw new \InvalidArgumentException("The URI must be given as a valid string");
      Severity: Minor
      Found in src/Core/Router/MatchableRouteTrait.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '181', column '23').
      Open

                  throw new \InvalidArgumentException("The URL must be given as a valid string");
      Severity: Minor
      Found in src/Core/Router/MatchableRouteTrait.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      There are no issues that match your filters.

      Category
      Status