Sign upLogin

NeroReflex/Gishiki

View on GitHub
Star
src/Database/Runtime/SelectionCriteria.php

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (($relation != FieldRelation::EQUAL) &&
            ($relation != FieldRelation::NOT_EQUAL) &&
            ($relation != FieldRelation::LESS_THAN) &&
            ($relation != FieldRelation::LESS_OR_EQUAL_THAN) &&
            ($relation != FieldRelation::GREATER_THAN) &&
Severity: Critical
Found in src/Database/Runtime/SelectionCriteria.php - About 2 hrs to fix

    Function where has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function where($clause, $field, $relation, $data)
    {
        if (!is_string($field) || (strlen($field) <= 0)) {
            throw new \InvalidArgumentException('the field name must be a string');
        }
    Severity: Minor
    Found in src/Database/Runtime/SelectionCriteria.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method where() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
    Open

        protected function where($clause, $field, $relation, $data)
    {
        if (!is_string($field) || (strlen($field) <= 0)) {
            throw new \InvalidArgumentException('the field name must be a string');
        }
    Severity: Minor
    Found in src/Database/Runtime/SelectionCriteria.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '83', column '23').
    Open

                throw new \InvalidArgumentException('the Relation between a column and its value must be expressed by one of FieldRelation constants');
    Severity: Minor
    Found in src/Database/Runtime/SelectionCriteria.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '86', column '23').
    Open

                throw new \InvalidArgumentException('the field data cannot be a php object or an extension native resource');
    Severity: Minor
    Found in src/Database/Runtime/SelectionCriteria.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '71', column '23').
    Open

                throw new \InvalidArgumentException('the field name must be a string');
    Severity: Minor
    Found in src/Database/Runtime/SelectionCriteria.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused private methods such as 'export'.
    Open

        private function export()
    {
        $export = [
            'historic' => $this->historic,
            'criteria' => $this->criteria,
    Severity: Minor
    Found in src/Database/Runtime/SelectionCriteria.php by phpmd

    UnusedPrivateMethod

    Since: 0.2

    Unused Private Method detects when a private method is declared but is unused.

    Example

    class Something
{
    private function foo() {} // unused
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

    There are no issues that match your filters.

    Category
    Status