Sign upLogin

Net-ng/kansha

View on GitHub
Star
kansha/card_addons/gallery/view.py

Summary

Maintainability
C
1 day
Test Coverage

Function render_image has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def render_image(self, h, comp, size, randomize=False, **kw):
Severity: Minor
Found in kansha/card_addons/gallery/view.py - About 45 mins to fix

    Function render_asset has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def render_asset(self, h, comp, model, *args):
    Severity: Minor
    Found in kansha/card_addons/gallery/view.py - About 35 mins to fix

      Function render_asset_anonymous has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def render_asset_anonymous(self, h, comp, model, *args):
      Severity: Minor
      Found in kansha/card_addons/gallery/view.py - About 35 mins to fix

        Function render_Asset_thumb has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def render_Asset_thumb(self, h, comp, model, *args):
        Severity: Minor
        Found in kansha/card_addons/gallery/view.py - About 35 mins to fix

          Function render_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def render_file(self, h, comp, size, **kw):
          Severity: Minor
          Found in kansha/card_addons/gallery/view.py - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            @presentation.render_for(Gallery, model='badge')
def render_gallery_badge(self, h, *args):
    """Gallery badge for the card"""
    num_assets = self.num_assets
    if num_assets:
            Severity: Major
            Found in kansha/card_addons/gallery/view.py and 1 other location - About 4 hrs to fix
            kansha/card_addons/comment/view.py on lines 111..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                        h << h.button(_('Create cover'), class_='btn btn-primary').action(self.commit, comp)
            Severity: Major
            Found in kansha/card_addons/gallery/view.py and 6 other locations - About 30 mins to fix
            kansha/board/templates.py on lines 62..62
            kansha/board/view.py on lines 344..344
            kansha/card_addons/gallery/view.py on lines 190..190
            kansha/card_addons/gallery/view.py on lines 192..192
            kansha/column/view.py on lines 193..193
            kansha/column/view.py on lines 195..195

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                        h << h.button(_('Cancel'), class_='btn').action(self.cancel, comp)
            Severity: Major
            Found in kansha/card_addons/gallery/view.py and 6 other locations - About 30 mins to fix
            kansha/board/templates.py on lines 62..62
            kansha/board/view.py on lines 344..344
            kansha/card_addons/gallery/view.py on lines 187..187
            kansha/card_addons/gallery/view.py on lines 190..190
            kansha/column/view.py on lines 193..193
            kansha/column/view.py on lines 195..195

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                            h << h.button(_('Remove cover'), class_='btn delete').action(self.remove_cover, comp)
            Severity: Major
            Found in kansha/card_addons/gallery/view.py and 6 other locations - About 30 mins to fix
            kansha/board/templates.py on lines 62..62
            kansha/board/view.py on lines 344..344
            kansha/card_addons/gallery/view.py on lines 187..187
            kansha/card_addons/gallery/view.py on lines 192..192
            kansha/column/view.py on lines 193..193
            kansha/column/view.py on lines 195..195

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status