Sign upLogin

Net-ng/kansha

View on GitHub
Star
kansha/card_addons/label/comp.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function write_extension_data_CardDescription has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def write_extension_data_CardDescription(self, sheet, row, col, style):
Severity: Minor
Found in kansha/card_addons/label/comp.py - About 35 mins to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        @property
    def data(self):
        """Return the label from the database

        Return:
    Severity: Major
    Found in kansha/card_addons/label/comp.py and 4 other locations - About 1 hr to fix
    kansha/board/comp.py on lines 526..533
    kansha/card/comp.py on lines 102..109
    kansha/card_addons/members/comp.py on lines 39..46
    kansha/column/comp.py on lines 118..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update_document(self, document):
        document.labels = u' '.join(label.get_title() for label in self.labels)
    Severity: Minor
    Found in kansha/card_addons/label/comp.py and 1 other location - About 40 mins to fix
    kansha/card_addons/checklist/comp.py on lines 221..222

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status