Sign upLogin

Net-ng/kansha

View on GitHub
Star
kansha/notifications.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function generate_email has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

def generate_email(app_title, board, user, hours, url, events):
    ret = []
    data = {'board': board.title, 'hours': hours, 'url': urlparse.urljoin(
        url, board.url), 'count': len(events), 'app': app_title}
    subject = _(
Severity: Minor
Found in kansha/notifications.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generate_email has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def generate_email(app_title, board, user, hours, url, events):
Severity: Minor
Found in kansha/notifications.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        for event in events:
                        if event.card:
                            # IDs are interpreted as anchors since HTML4. So don't use the ID of
                            # the card as a URL fragment, because the browser
                            # jumps to it.
    Severity: Major
    Found in kansha/notifications.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status