Sign upLogin

Nick9500/ministocks

View on GitHub
Star
src/main/java/nitezh/ministock/SymbolProvider.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method getSuggestions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public Cursor getSuggestions(String query) {
        query = query == null ? "" : query.toLowerCase().trim();
        List<Map<String, String>> suggestions = StockSuggestions.getSuggestions(query);

        // Check whether an exact match is found in the symbol
Severity: Minor
Found in src/main/java/nitezh/ministock/SymbolProvider.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getSuggestions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Cursor getSuggestions(String query) {
        query = query == null ? "" : query.toLowerCase().trim();
        List<Map<String, String>> suggestions = StockSuggestions.getSuggestions(query);

        // Check whether an exact match is found in the symbol
Severity: Minor
Found in src/main/java/nitezh/ministock/SymbolProvider.java - About 1 hr to fix

    Method query has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public Cursor query(Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
    Severity: Minor
    Found in src/main/java/nitezh/ministock/SymbolProvider.java - About 35 mins to fix

      Method query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public Cursor query(Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
        if (!TextUtils.isEmpty(selection)) {
            throw new IllegalArgumentException("selection not allowed for " + uri);
        }
      Severity: Minor
      Found in src/main/java/nitezh/ministock/SymbolProvider.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status