Sign upLogin

Nick9500/ministocks

View on GitHub
Star
src/main/java/nitezh/ministock/activities/PortfolioActivity.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method showPortfolioItemEdit has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void showPortfolioItemEdit(AdapterView<?> a, int position) {
        // Create the portfolio item edit dialog
        final Dialog portfolioItemEdit = new Dialog(this);
        portfolioItemEdit.setContentView(R.layout.portfolio_item);
Severity: Major
Found in src/main/java/nitezh/ministock/activities/PortfolioActivity.java - About 3 hrs to fix

    Method showPortfolioItemEdit has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        private void showPortfolioItemEdit(AdapterView<?> a, int position) {
        // Create the portfolio item edit dialog
        final Dialog portfolioItemEdit = new Dialog(this);
        portfolioItemEdit.setContentView(R.layout.portfolio_item);
    Severity: Minor
    Found in src/main/java/nitezh/ministock/activities/PortfolioActivity.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method refreshView has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void refreshView() {
        setContentView(R.layout.portfolio);

        List<Map<String, String>> listViewData = this.portfolioRepository.getDisplayInfo();
        SimpleAdapter adapter = new SimpleAdapter(this, listViewData, R.layout.portfolio_list_item,
    Severity: Minor
    Found in src/main/java/nitezh/ministock/activities/PortfolioActivity.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status