Sign upLogin

Nick9500/ministocks

View on GitHub
Star
src/main/java/nitezh/ministock/activities/PreferencesActivity.java

Summary

Maintainability
F
5 days
Test Coverage

File PreferencesActivity.java has 764 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 The MIT License

 Copyright (c) 2013 Nitesh Patel http://niteshpatel.github.io/ministocks
Severity: Major
Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 1 day to fix

    PreferencesActivity has 70 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class PreferencesActivity extends PreferenceActivity implements OnSharedPreferenceChangeListener {

    // Constants
    private static final int STRING_TYPE = 0;
    private static final int LIST_TYPE = 1;
    Severity: Major
    Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 1 day to fix

      Method onCreate has 245 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        addPreferencesFromResource(R.xml.preferences);
      Severity: Major
      Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 1 day to fix

        Method updateSummaries has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            private void updateSummaries(SharedPreferences sharedPreferences, String key) {
        Preference preference = findPreference(key);

        if (preference != null) {
        Severity: Minor
        Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method sendEmailToUser has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void sendEmailToUser() {

        // Set up the input
        final EditText input = new EditText(this);
        input.setId(R.id.emailFieldID);
        Severity: Major
        Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 2 hrs to fix

          Method updateSummaries has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private void updateSummaries(SharedPreferences sharedPreferences, String key) {
        Preference preference = findPreference(key);

        if (preference != null) {
          Severity: Major
          Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 2 hrs to fix

            Method onResume has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Override
    protected void onResume() {
        super.onResume();
            Severity: Minor
            Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 1 hr to fix

              Method onResume has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  @Override
    protected void onResume() {
        super.onResume();
              Severity: Minor
              Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method onSharedPreferenceChanged has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  @Override
    public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) {
        // Perform some custom handling of some values

        if (key.startsWith("Stock") && !key.endsWith("_summary")) {
              Severity: Minor
              Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method updateFromGlobal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void updateFromGlobal(SharedPreferences sharedPreferences, String key, int valType) {
        // Unregister the listener whenever a key changes
        getPreferenceScreen().getSharedPreferences().unregisterOnSharedPreferenceChangeListener(this);

        // Update the widget preferences with the interval
              Severity: Minor
              Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (value != null && !value.equals("")) {
            String[] items = value.split(":");
            mHour = Integer.parseInt(items[0]);
            mMinute = Integer.parseInt(items[1]);
        }
              Severity: Minor
              Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java and 1 other location - About 35 mins to fix
              src/main/java/nitezh/ministock/activities/PreferencesActivity.java on lines 778..782

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (value != null) {
                    String[] items = value.split(":");
                    mHour = Integer.parseInt(items[0]);
                    mMinute = Integer.parseInt(items[1]);
                }
              Severity: Minor
              Found in src/main/java/nitezh/ministock/activities/PreferencesActivity.java and 1 other location - About 35 mins to fix
              src/main/java/nitezh/ministock/activities/PreferencesActivity.java on lines 367..371

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status