Nick9500/ministocks

View on GitHub
src/main/java/nitezh/ministock/domain/AndroidWidget.java

Summary

Maintainability
B
6 hrs
Test Coverage

AndroidWidget has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

class AndroidWidget implements Widget {

    private final Storage storage;
    private final Context context;
    private final int id;
Severity: Minor
Found in src/main/java/nitezh/ministock/domain/AndroidWidget.java - About 5 hrs to fix

    Method setWidgetPreferencesFromJson has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
        public void setWidgetPreferencesFromJson(JSONObject jsonPrefs) {
            String key;
            for (Iterator preferenceKey = jsonPrefs.keys(); preferenceKey.hasNext(); ) {
                key = (String) preferenceKey.next();
    Severity: Minor
    Found in src/main/java/nitezh/ministock/domain/AndroidWidget.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status