Sign upLogin

Nickersoft/push.js

View on GitHub
Star
src/push/Permission.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function _requestWithCallback has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    _requestWithCallback(onGranted: () => void, onDenied: () => void) {
        const existing = this.get();

        var resolved = false;
        var resolve = (result = this._win.Notification.permission) => {
Severity: Minor
Found in src/push/Permission.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _requestWithCallback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _requestWithCallback(onGranted: () => void, onDenied: () => void) {
        const existing = this.get();

        var resolved = false;
        var resolve = (result = this._win.Notification.permission) => {
Severity: Minor
Found in src/push/Permission.js - About 1 hr to fix

    Function _requestAsPromise has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _requestAsPromise(): Promise<void> {
        const existing = this.get();

        let isGranted = result => result === this.GRANTED || result === 0;
    Severity: Minor
    Found in src/push/Permission.js - About 1 hr to fix

      Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          get() {
        let permission;

        /* Safari 6+, Chrome 23+ */
        if (this._win.Notification && this._win.Notification.permission)
      Severity: Minor
      Found in src/push/Permission.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Parsing error: Unexpected token {
      Open

      import type { Global } from 'types';
      Severity: Minor
      Found in src/push/Permission.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status