Sign upLogin

Nickersoft/push.js

View on GitHub
Star

Showing 27 of 27 total issues

Function _createCallback has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    _createCallback(
        title: string,
        options: PushOptions,
        resolve: ({} | null) => void
    ) {
Severity: Minor
Found in src/push/Push.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _requestWithCallback has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    _requestWithCallback(onGranted: () => void, onDenied: () => void) {
        const existing = this.get();

        var resolved = false;
        var resolve = (result = this._win.Notification.permission) => {
Severity: Minor
Found in src/push/Permission.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Push.js has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
import { Messages, Permission, Util } from 'push';
import type { PluginManifest, GenericNotification, PushOptions } from 'types';

/* Import notification agents */
Severity: Minor
Found in src/push/Push.js - About 2 hrs to fix

    Function _createCallback has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _createCallback(
        title: string,
        options: PushOptions,
        resolve: ({} | null) => void
    ) {
    Severity: Major
    Found in src/push/Push.js - About 2 hrs to fix

      Function create has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          create(
        id: number,
        title: string,
        options: PushOptions,
        serviceWorker: string,
      Severity: Minor
      Found in src/agents/MobileChromeAgent.js - About 1 hr to fix

        Function onnotificationclick has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        self.onnotificationclick = function(event) {
    var link, origin, href;

    if (
        typeof event.notification.data.link !== 'undefined' &&
        Severity: Minor
        Found in src/serviceWorker.js - About 1 hr to fix

          Function _requestWithCallback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _requestWithCallback(onGranted: () => void, onDenied: () => void) {
        const existing = this.get();

        var resolved = false;
        var resolve = (result = this._win.Notification.permission) => {
          Severity: Minor
          Found in src/push/Permission.js - About 1 hr to fix

            Function _requestAsPromise has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _requestAsPromise(): Promise<void> {
        const existing = this.get();

        let isGranted = result => result === this.GRANTED || result === 0;
            Severity: Minor
            Found in src/push/Permission.js - About 1 hr to fix

              Function extend has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  extend(manifest: PluginManifest) {
        var plugin,
            Plugin,
            hasProp = {}.hasOwnProperty;
              Severity: Minor
              Found in src/push/Push.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  isSupported() {
        return (
            this._win.navigator !== undefined &&
            this._win.navigator.serviceWorker !== undefined
        );
              Severity: Minor
              Found in src/agents/MobileChromeAgent.js and 1 other location - About 35 mins to fix
              src/agents/MSAgent.js on lines 16..21

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  isSupported() {
        return (
            this._win.external !== undefined &&
            this._win.external.msIsSiteMode !== undefined
        );
              Severity: Minor
              Found in src/agents/MSAgent.js and 1 other location - About 35 mins to fix
              src/agents/MobileChromeAgent.js on lines 17..22

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function onnotificationclick has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              self.onnotificationclick = function(event) {
    var link, origin, href;

    if (
        typeof event.notification.data.link !== 'undefined' &&
              Severity: Minor
              Found in src/serviceWorker.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  get() {
        let permission;

        /* Safari 6+, Chrome 23+ */
        if (this._win.Notification && this._win.Notification.permission)
              Severity: Minor
              Found in src/push/Permission.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _closeNotification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  _closeNotification(id: number | string) {
        let success = true;
        const notification = this._notifications[id];

        if (notification !== undefined) {
              Severity: Minor
              Found in src/push/Push.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function objectMerge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  static objectMerge(target, source) {
        for (var key in source) {
            if (
                target.hasOwnProperty(key) &&
                this.isObject(target[key]) &&
              Severity: Minor
              Found in src/push/Util.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function close has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  close(tag: string) {
        let key, notification;

        for (key in this._notifications) {
            if (this._notifications.hasOwnProperty(key)) {
              Severity: Minor
              Found in src/push/Push.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Parsing error: Unexpected token {
              Open

              import type { Global, PushOptions } from 'types';
              Severity: Minor
              Found in src/agents/MobileFirefoxAgent.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Parsing error: Unexpected token {
              Open

              import type { PushOptions, Global } from 'types';
              Severity: Minor
              Found in src/agents/MSAgent.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Parsing error: Unexpected token {
              Open

              import type { Global, GenericNotification, PushOptions } from 'types';
              Severity: Minor
              Found in src/agents/MobileChromeAgent.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Parsing error: Unexpected token {
              Open

              import type { Global } from 'types';
              Severity: Minor
              Found in src/push/Permission.js by eslint

              For more information visit Source: http://eslint.org/docs/rules/

              Severity
              Category
              Status
              Source
              Language