Sign upLogin

Nickersoft/push.js

View on GitHub
Star
src/push/Push.js

Summary

Maintainability
C
1 day
Test Coverage

Function _createCallback has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    _createCallback(
        title: string,
        options: PushOptions,
        resolve: ({} | null) => void
    ) {
Severity: Minor
Found in src/push/Push.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Push.js has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
import { Messages, Permission, Util } from 'push';
import type { PluginManifest, GenericNotification, PushOptions } from 'types';

/* Import notification agents */
Severity: Minor
Found in src/push/Push.js - About 2 hrs to fix

    Function _createCallback has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _createCallback(
        title: string,
        options: PushOptions,
        resolve: ({} | null) => void
    ) {
    Severity: Major
    Found in src/push/Push.js - About 2 hrs to fix

      Function extend has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          extend(manifest: PluginManifest) {
        var plugin,
            Plugin,
            hasProp = {}.hasOwnProperty;
      Severity: Minor
      Found in src/push/Push.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _closeNotification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          _closeNotification(id: number | string) {
        let success = true;
        const notification = this._notifications[id];

        if (notification !== undefined) {
      Severity: Minor
      Found in src/push/Push.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function close has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          close(tag: string) {
        let key, notification;

        for (key in this._notifications) {
            if (this._notifications.hasOwnProperty(key)) {
      Severity: Minor
      Found in src/push/Push.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Parsing error: Unexpected token {
      Open

      import type { PluginManifest, GenericNotification, PushOptions } from 'types';
      Severity: Minor
      Found in src/push/Push.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status