Sign upLogin

NicolasSiver/nodebb-widget-ns-stats

View on GitHub
Star

Showing 4 of 4 total issues

Function getOnline has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    Users.getOnline = function (done) {
        var now = Date.now();
        if (now - lastRequestAt > onlineCache) {
            var usersOnline, usersToFetch, usersInCache;
            async.waterfall([
Severity: Minor
Found in widget/users.js - About 1 hr to fix

    Function start has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        Job.start = function (done) {
        if (working) {
            return done(new Error('Job is in progress. You can not start another'));
        }
    Severity: Minor
    Found in widget/job.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (pluginId === require('../plugin.json').id) {
                    controller.dispose(function (error) {
                        if (error) {
                            return logger.log('error', '%s', error);
                        }
      Severity: Minor
      Found in widget/index.js and 1 other location - About 50 mins to fix
      widget/controller.js on lines 22..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              setTimeout(function defer() {
            job.start(function (error) {
                if (error) {
                    return logger.log('error', 'Initial error has occurred. %s', error);
                }
      Severity: Minor
      Found in widget/controller.js and 1 other location - About 50 mins to fix
      widget/index.js on lines 12..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language