Sign upLogin

NikolaGavric94/laravel-square

View on GitHub
Star
src/SquareService.php

Summary

Maintainability
C
1 day
Test Coverage
B
87%

File SquareService.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Nikolag\Square;

use Nikolag\Core\Abstracts\CorePaymentService;
Severity: Minor
Found in src/SquareService.php - About 2 hrs to fix

Method charge has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function charge(array $options): Transaction
    {
        $location_id = array_key_exists('location_id', $options) ? $options['location_id'] : null;
        $currency = array_key_exists('currency', $options) ? $options['currency'] : 'USD';
        $prepData = [
Severity: Major
Found in src/SquareService.php - About 2 hrs to fix

Function charge has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function charge(array $options): Transaction
    {
        $location_id = array_key_exists('location_id', $options) ? $options['location_id'] : null;
        $currency = array_key_exists('currency', $options) ? $options['currency'] : 'USD';
        $prepData = [
Severity: Minor
Found in src/SquareService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _saveCustomer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function _saveCustomer(): void
    {
        if (! $this->getCustomer()->payment_service_id) {
            $response = $this->config->customersAPI()->createCustomer($this->getCreateCustomerRequest());
Severity: Minor
Found in src/SquareService.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _saveOrder has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function _saveOrder(bool $saveToSquare = false): void
    {
        $this->order = $this->orderBuilder->buildOrderFromOrderCopy($this->getOrder(), $this->orderCopy);
        //If property locationId doesn't exist throw error
        if (! $this->locationId) {
Severity: Minor
Found in src/SquareService.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status