Sign upLogin

NikolaGavric94/laravel-square

View on GitHub
Star
src/utils/Util.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
93%

Consider simplifying this complex logical expression.
Open

                if ((! $discount->pivot && $discount->scope === Constants::DEDUCTIBLE_SCOPE_PRODUCT) ||
                    ($discount->pivot && $discount->pivot->scope === Constants::DEDUCTIBLE_SCOPE_PRODUCT)) {
                    return self::_calculateProductDiscounts($products, $discount);
                } elseif ((! $discount->pivot && $discount->scope === Constants::DEDUCTIBLE_SCOPE_ORDER) ||
                        ($discount->pivot && $discount->pivot->scope === Constants::DEDUCTIBLE_SCOPE_ORDER)) {
Severity: Major
Found in src/utils/Util.php - About 1 hr to fix

Avoid too many return statements within this method.
Open

        return $totalDiscount;
Severity: Major
Found in src/utils/Util.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in src/utils/Util.php - About 30 mins to fix

Function hasProduct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static function hasProduct(\Illuminate\Database\Eloquent\Collection|Collection $source, Product|int|array|null $product): bool
    {
        // Check if $product is either int, Model or array
        if (is_a($product, Product::class)) {
            return $source->contains($product);
Severity: Minor
Found in src/utils/Util.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status