Sign upLogin

NoNameItem/django-magnificent-messages

View on GitHub
Star
django_magnificent_messages/storage/message_storage/base.py

Summary

Maintainability
A
0 mins
Test Coverage
C
72%

Cyclomatic complexity is too high in method send_message. (7)
Open

    def send_message(self,
                     level: int,
                     text: str,
                     subject: str = None,
                     extra: object = None,
Severity: Minor
Found in django_magnificent_messages/storage/message_storage/base.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Method "_save_message" has 8 parameters, which is greater than the 7 authorized.
Open

    def _save_message(self,
                      message: Message,
                      author_pk,
                      to_users_pk: Iterable,
                      to_groups_pk: Iterable,
Severity: Major
Found in django_magnificent_messages/storage/message_storage/base.py by sonar-python

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...

Method "__init__" has 8 parameters, which is greater than the 7 authorized.
Open

    def __init__(self, convert_function, fetch_all, object_list, number, paginator, *args, **kwargs):
Severity: Major
Found in django_magnificent_messages/storage/message_storage/base.py by sonar-python

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...

Method "send_message" has 10 parameters, which is greater than the 7 authorized.
Open

    def send_message(self,
                     level: int,
                     text: str,
                     subject: str = None,
                     extra: object = None,
Severity: Major
Found in django_magnificent_messages/storage/message_storage/base.py by sonar-python

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...

There are no issues that match your filters.

Category
Status