Sign upLogin

NoNameItem/django-magnificent-messages

View on GitHub
Star
django_magnificent_messages/storage/message_storage/db.py

Summary

Maintainability
A
0 mins
Test Coverage
A
93%

Method "_save_message" has 8 parameters, which is greater than the 7 authorized.
Open

    def _save_message(self, message: Message, author_pk, to_users_pk: Iterable, to_groups_pk: Iterable,
                      user_generated: bool = True, html_safe: bool = False, reply_to_pk=None) -> StoredMessage:
Severity: Major
Found in django_magnificent_messages/storage/message_storage/db.py by sonar-python

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...

Remove this commented out code.
Open

                # raw_text=stored.raw_text,
Severity: Major
Found in django_magnificent_messages/storage/message_storage/db.py by sonar-python

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

See

  • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
  • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
  • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
  • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

There are no issues that match your filters.

Category
Status