Sign upLogin

Noctis/kickstart

View on GitHub
Star

Showing 8 of 79 total issues

Request has 33 functions (exceeds 20 allowed). Consider refactoring.
Open

class Request implements ServerRequestInterface
{
    public function __construct(
        protected ServerRequestInterface $request
    ) {
Severity: Minor
Found in src/Http/Request/Request.php - About 4 hrs to fix

    Method makeDisposition has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function makeDisposition(string $disposition, string $filename, string $filenameFallback = ''): string
    {
        if (!\in_array($disposition, [self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE])) {
            throw new InvalidArgumentException(
                sprintf(
    Severity: Minor
    Found in src/Http/Helper/HeaderUtils.php - About 1 hr to fix

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 24 and the first side effect is on line 20.
      Open

      <?php
      Severity: Minor
      Found in src/Http/Routing/Router/FastRouteRouter.php by phpcodesniffer

      Function makeDisposition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function makeDisposition(string $disposition, string $filename, string $filenameFallback = ''): string
    {
        if (!\in_array($disposition, [self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE])) {
            throw new InvalidArgumentException(
                sprintf(
      Severity: Minor
      Found in src/Http/Helper/HeaderUtils.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Scope keyword "static" must be followed by a single space
      Open

          public static function boot(ServicesProviderInterface ...$servicesProviders): static
      Severity: Minor
      Found in src/AbstractApplication.php by phpcodesniffer

      Line indented incorrectly; expected 4 spaces, found 8
      Open

              protected readonly SettableContainerInterface $container,
      Severity: Minor
      Found in src/AbstractApplication.php by phpcodesniffer

      Expected 0 spaces after opening bracket; newline found
      Open

              if (
      Severity: Minor
      Found in src/Http/Helper/HeaderUtils.php by phpcodesniffer

      Line indented incorrectly; expected 4 spaces, found 8
      Open

              protected readonly RouterInterface            $router,
      Severity: Minor
      Found in src/AbstractApplication.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language