NodeBB/NodeBB

View on GitHub

Showing 444 of 553 total issues

Avoid too many return statements within this function.
Open

        return await prompt.get(questions.postgres);
Severity: Major
Found in install/databases.js - About 30 mins to fix

    Function exports has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    module.exports = function (SocketTopics) {
        SocketTopics.loadTopicTools = async function (socket, data) {
            if (!socket.uid) {
                throw new Error('[[error:no-privileges]]');
            }
    Severity: Minor
    Found in src/socket.io/topics/tools.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fireFilterHook has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    async function fireFilterHook(hook, hookList, params) {
        if (!Array.isArray(hookList) || !hookList.length) {
            return params;
        }
    
    
    Severity: Minor
    Found in src/plugins/hooks.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function build has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    exports.build = async function (targets, options) {
        if (!options) {
            options = {};
        }
    
    
    Severity: Minor
    Found in src/meta/build.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function connect has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    connection.connect = async function (options) {
        return new Promise((resolve, reject) => {
            options = options || nconf.get('redis');
            const redis_socket_or_host = options.host;
    
    
    Severity: Minor
    Found in src/database/redis/connection.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function login has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    authenticationController.login = async (req, res, next) => {
        let { strategy } = await plugins.hooks.fire('filter:login.override', { req, strategy: 'local' });
        if (!passport._strategy(strategy)) {
            winston.error(`[auth/override] Requested login strategy "${strategy}" not found, reverting back to local login strategy.`);
            strategy = 'local';
    Severity: Minor
    Found in src/controllers/authentication.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateForTopic has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    async function generateForTopic(req, res, next) {
        if (meta.config['feeds:disableRSS']) {
            return next();
        }
    
    
    Severity: Minor
    Found in src/routes/feeds.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function redirect has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    helpers.redirect = function (res, url, permanent) {
        // this is used by sso plugins to redirect to the auth route
        // { external: '/auth/sso' } or { external: 'https://domain/auth/sso' }
        if (url.hasOwnProperty('external')) {
            const redirectUrl = encodeURI(prependRelativePath(url.external));
    Severity: Minor
    Found in src/controllers/helpers.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function details has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    groupsController.details = async function (req, res, next) {
        const lowercaseSlug = req.params.slug.toLowerCase();
        if (req.params.slug !== lowercaseSlug) {
            if (res.locals.isAPI) {
                req.params.slug = lowercaseSlug;
    Severity: Minor
    Found in src/controllers/groups.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    pagination.create = function (currentPage, pageCount, queryObj) {
        if (pageCount <= 1) {
            return {
                prev: { page: 1, active: currentPage > 1 },
                next: { page: 1, active: currentPage < pageCount },
    Severity: Minor
    Found in src/pagination.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    chatsController.get = async function (req, res, next) {
        if (meta.config.disableChat) {
            return next();
        }
    
    
    Severity: Minor
    Found in src/controllers/accounts/chats.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addTags has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    async function addTags(topicData, req, res, currentPage) {
        const postIndex = parseInt(req.params.post_index, 10) || 0;
        const postAtIndex = topicData.posts.find(p => parseInt(p.index, 10) === parseInt(Math.max(0, postIndex - 1), 10));
        let description = '';
        if (postAtIndex && postAtIndex.content) {
    Severity: Minor
    Found in src/controllers/topics.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function method has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        method: function (callback) {
            db.getObjectField('config', 'customJS', (err, newHTML) => {
                if (err) {
                    return callback(err);
                }
    Severity: Minor
    Found in src/upgrades/1.7.0/generate-custom-html.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function gdpr has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    Interstitials.gdpr = async function (data) {
        if (!meta.config.gdpr_enabled || (data.userData && data.userData.gdpr_consent)) {
            return data;
        }
        if (!data.userData) {
    Severity: Minor
    Found in src/user/interstitials.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getNotifications has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    UserNotifications.getNotifications = async function (nids, uid) {
        if (!Array.isArray(nids) || !nids.length) {
            return [];
        }
    
    
    Severity: Minor
    Found in src/user/notifications.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getCover has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    function getCover(type, id) {
        const defaultCover = `${relative_path}/assets/images/cover-default.png`;
        if (meta.config[`${type}:defaultCovers`]) {
            const covers = String(meta.config[`${type}:defaultCovers`]).trim().split(/[\s,]+/g);
            let coverPhoto = defaultCover;
    Severity: Minor
    Found in src/coverPhoto.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function method has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

        method: async function () {
            const groupsAPI = require('../../groups');
            const privilegesAPI = require('../../privileges');
    
            const cids = await db.getSortedSetRange('categories:cid', 0, -1);
    Severity: Minor
    Found in src/upgrades/1.1.0/assign_topic_read_privilege.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function searchInContent has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    async function searchInContent(data) {
        data.uid = data.uid || 0;
    
        const [searchCids, searchUids] = await Promise.all([
            getSearchCids(data),
    Severity: Minor
    Found in src/search.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    Flags.create = async function (type, id, uid, reason, timestamp, forceFlag = false) {
        let doHistoryAppend = false;
        if (!timestamp) {
            timestamp = Date.now();
            doHistoryAppend = true;
    Severity: Minor
    Found in src/flags.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    usersAPI.update = async function (caller, data) {
        if (!caller.uid) {
            throw new Error('[[error:invalid-uid]]');
        }
    
    
    Severity: Minor
    Found in src/api/users.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language