Sign upLogin

Noosfero/noosfero

View on GitHub
Star
app/concerns/authenticated_system.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method login_required has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def login_required
      username, passwd = get_auth_data
      if username && passwd
        self.current_user ||= User.authenticate(username, passwd) || nil
      end
Severity: Minor
Found in app/concerns/authenticated_system.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method login_from_cookie has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def login_from_cookie
      return if cookies[:auth_token].blank? || logged_in?

      token = cookies[:auth_token].to_s.match(/auth_token=(.*);/)
      token = token ? token[1] : nil
Severity: Minor
Found in app/concerns/authenticated_system.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status