Sign upLogin

Noosfero/noosfero

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class ApplicationController has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  protect_from_forgery

  before_action :detect_stuff_by_domain
  before_action :init_noosfero_plugins
Severity: Minor
Found in app/controllers/application_controller.rb - About 2 hrs to fix

    Method detect_stuff_by_domain has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def detect_stuff_by_domain
      # Sets text domain based on request host for custom internationalization
      FastGettext.text_domain = Domain.custom_locale(request.host)

      @domain = Domain.by_name(request.host)
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method allow_cross_domain_access has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def allow_cross_domain_access
    origin = request.headers["Origin"]
    return if origin.blank?

    if environment.access_control_allow_origin.include? origin
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status