Sign upLogin

Noosfero/noosfero

View on GitHub
Star
app/controllers/my_profile/profile_editor_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Class ProfileEditorController has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class ProfileEditorController < MyProfileController
  protect "edit_profile", :profile, except: [:destroy_profile]
  protect "destroy_profile", :profile, only: [:destroy_profile]

  skip_before_action :verify_authenticity_token, only: [:google_map]
Severity: Minor
Found in app/controllers/my_profile/profile_editor_controller.rb - About 2 hrs to fix

    Method informations has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def informations
    @profile_data = profile
    @kinds = environment.kinds.where(type: profile.type)
    profile_params = params[:profile_data].to_h
    Severity: Minor
    Found in app/controllers/my_profile/profile_editor_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method remote_edit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def remote_edit
    if request.post?
      if profile.update(params[:profile_data])
        if params.has_key?(:field)
          response = render_to_string(partial: "profile_editor/edit_in_place_field",
    Severity: Minor
    Found in app/controllers/my_profile/profile_editor_controller.rb - About 1 hr to fix

      Method destroy_profile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def destroy_profile
    if request.post?
      if @profile.destroy
        session[:notice] = _("The profile was deleted.")
        if (params[:return_to])
      Severity: Minor
      Found in app/controllers/my_profile/profile_editor_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method locality has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def locality
    @profile_data = profile
    if request.post?
      begin
        country = params[:profile_data][:country]
      Severity: Minor
      Found in app/controllers/my_profile/profile_editor_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method remote_edit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def remote_edit
    if request.post?
      if profile.update(params[:profile_data])
        if params.has_key?(:field)
          response = render_to_string(partial: "profile_editor/edit_in_place_field",
      Severity: Minor
      Found in app/controllers/my_profile/profile_editor_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_profile_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def update_profile_data
      @profile_data = profile
      if request.post?
        begin
          @profile_data.update!(params[:profile_data])
      Severity: Minor
      Found in app/controllers/my_profile/profile_editor_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def categories
    regions = profile.categories.where(type: "Region").map(&:id).map(&:to_s)
    params[:profile_data][:category_ids] += regions if params[:profile_data].present?
    update_profile_data
      Severity: Minor
      Found in app/controllers/my_profile/profile_editor_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/my_profile/profile_editor_controller.rb on lines 90..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def regions
    categories = profile.categories.where(type: "Category").map(&:id).map(&:to_s)
    params[:profile_data][:category_ids] += categories if params[:profile_data].present?
    update_profile_data
      Severity: Minor
      Found in app/controllers/my_profile/profile_editor_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/my_profile/profile_editor_controller.rb on lines 84..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status