Sign upLogin

Noosfero/noosfero

View on GitHub
Star
app/helpers/article_helper.rb

Summary

Maintainability
D
2 days
Test Coverage

Method article_actions has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

  def article_actions
    actions = [following_button(@page, user)]

    if @page.allow_edit?(user) && !remove_content_button(:edit, @page)
      content = font_awesome(:edit, label_for_edit_article(@page))
Severity: Minor
Found in app/helpers/article_helper.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method article_actions has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def article_actions
    actions = [following_button(@page, user)]

    if @page.allow_edit?(user) && !remove_content_button(:edit, @page)
      content = font_awesome(:edit, label_for_edit_article(@page))
Severity: Major
Found in app/helpers/article_helper.rb - About 2 hrs to fix

    Method custom_options_for_article has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def custom_options_for_article(article, tokenized_children)
    @article = article

    visibility_options(@article, tokenized_children) +
      topic_creation(@article) +
    Severity: Minor
    Found in app/helpers/article_helper.rb - About 1 hr to fix

      Method add_option_to_followers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def add_option_to_followers(article, tokenized_children)
    return if article.profile.person?

    label_message = _("Community members will not view this content")
      Severity: Minor
      Found in app/helpers/article_helper.rb - About 1 hr to fix

        Method custom_options_for_article has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def custom_options_for_article(article, tokenized_children)
    @article = article

    visibility_options(@article, tokenized_children) +
      topic_creation(@article) +
        Severity: Minor
        Found in app/helpers/article_helper.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

            if !@page.allow_create?(user) && profile.organization? && (@page.blog? || @page.parent && @page.parent.blog?) && !remove_content_button(:suggest, @page)
      content = font_awesome(:lightbulb, _("Suggest an article"))
      url = profile.admin_url.merge(controller: "cms", action: "suggest_an_article")
      options = { id: "suggest-article-link" }
      actions << link_to(content, url, options)
        Severity: Major
        Found in app/helpers/article_helper.rb - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                plugin_button[:html_options] ||= {}
      plugin_button[:html_options][:title] ||= plugin_button[:title]
      title = font_awesome(plugin_button[:icon], plugin_button[:title])
      actions << link_to(title, plugin_button[:url], plugin_button[:html_options])
          Severity: Minor
          Found in app/helpers/article_helper.rb and 1 other location - About 30 mins to fix
          app/helpers/application_helper.rb on lines 986..989

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status