Sign upLogin

Noosfero/noosfero

View on GitHub
Star
app/helpers/boxes_helper.rb

Summary

Maintainability
D
1 day
Test Coverage

File boxes_helper.rb has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BoxesHelper
  include SanitizeHelper
  include ActionView::Helpers::OutputSafetyHelper

  def insert_boxes(content)
Severity: Minor
Found in app/helpers/boxes_helper.rb - About 3 hrs to fix

    Method block_edit_buttons has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def block_edit_buttons(block)
    buttons = []
    nowhere = "javascript: return false;"

    if movable?(block)
    Severity: Minor
    Found in app/helpers/boxes_helper.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method block_edit_buttons has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def block_edit_buttons(block)
    buttons = []
    nowhere = "javascript: return false;"

    if movable?(block)
    Severity: Major
    Found in app/helpers/boxes_helper.rb - About 2 hrs to fix

      Method render_block has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def render_block(block, prefix = nil, klass = block.class)
    template_name = klass.name.demodulize.underscore.sub "_block", ""
    method_name = "#{template_name}_block_extra_content"
    begin
      block_content = render template: "blocks/#{prefix}#{template_name}", locals: { block: block }
      Severity: Minor
      Found in app/helpers/boxes_helper.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method display_block_content has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def display_block_content(block, main_content = nil)
    content = nil
    if block.main?
      content = wrap_main_content(main_content)
    else
      Severity: Minor
      Found in app/helpers/boxes_helper.rb - About 1 hr to fix

        Method select_blocks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.select_blocks(box, arr, context)
      arr = arr.select { |block| block.visible? context }

      custom_design = context[:controller].send(:custom_design)
      inserts = [custom_design[:insert]].flatten.compact
        Severity: Minor
        Found in app/helpers/boxes_helper.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method display_block_content has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def display_block_content(block, main_content = nil)
    content = nil
    if block.main?
      content = wrap_main_content(main_content)
    else
        Severity: Minor
        Found in app/helpers/boxes_helper.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method insert_boxes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def insert_boxes(content)
    if controller.send(:boxes_editor?) && controller.send(:uses_design_blocks?)
      content + display_boxes_editor(controller.boxes_holder)
    else
      maybe_display_custom_element(controller.boxes_holder, :custom_header_expanded, id: "profile-header") +
        Severity: Minor
        Found in app/helpers/boxes_helper.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if block.last?
        buttons << button_without_text(:down, _("Can't move down anymore."),
                                       nowhere, class: "disabled")
      else
        buttons << button_without_text(:down, _("Move block down"),
        Severity: Minor
        Found in app/helpers/boxes_helper.rb and 1 other location - About 20 mins to fix
        app/helpers/boxes_helper.rb on lines 260..266

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if block.first?
        buttons << button_without_text(:up, _("Can't move up anymore."),
                                       nowhere, class: "disabled")
      else
        buttons << button_without_text(:up, _("Move block up"),
        Severity: Minor
        Found in app/helpers/boxes_helper.rb and 1 other location - About 20 mins to fix
        app/helpers/boxes_helper.rb on lines 269..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status