Sign upLogin

Noosfero/noosfero

View on GitHub
Star
app/models/task.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Task has 46 methods (exceeds 20 allowed). Consider refactoring.
Open

class Task < ApplicationRecord
  extend ActsAsHavingSettings::ClassMethods
  acts_as_having_settings field: :data

  store_accessor :metadata
Severity: Minor
Found in app/models/task.rb - About 6 hrs to fix

    File task.rb has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Task < ApplicationRecord
  extend ActsAsHavingSettings::ClassMethods
  acts_as_having_settings field: :data

  store_accessor :metadata
    Severity: Minor
    Found in app/models/task.rb - About 3 hrs to fix

      Method validate_each has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def validate_each(record, attribute, value)
      environment = record.environment || Environment.default
      klass = options[:kind]
      group = klass.to_s.downcase.pluralize
      id = attribute.to_s + "_id"
      Severity: Minor
      Found in app/models/task.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method send_notification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def send_notification(action)
      if sends_email?
        begin
          if self.requestor && !self.requestor.notification_emails.empty?
            notify(:generic_message, "task_#{action}", self)
      Severity: Minor
      Found in app/models/task.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status